SotMSteamMods / CauldronMods

Mod adaptations of the Cauldron decks for Sentinels of the Multiverse for Steam Workshop
MIT License
15 stars 9 forks source link

If Parse's Buffer Overflow is recycled by Mara's Wand of Banishment, it loses its effect when replayed. #1637

Open archwaykitten opened 1 year ago

archwaykitten commented 1 year ago

Describe the bug I stumbled across a fun combo: Parse uses Buffer Overflow to prevent a villain's card play -> Mara uses Wand of Banishment to put Buffer Overflow on the top (or bottom) of Parse's deck -> Since Wand of Banishment prevented Buffer Overflow from being destroyed, Buffer Overflow does not play the top card of the villain deck, resulting in full villain lockdown.

That all works great. The bug occurs when Parse replays that same Buffer Overflow. The next time that same Buffer Overflow is in play and should trigger, it does nothing instead. The villain can keep playing cards and Buffer Overflow never interrupts.

What does it affect Card(s): Buffer Overflow, Wand of Banishment Deck(s): Parse, Magnificent Mara.

To Reproduce Steps to reproduce the behavior:

  1. Play a game with Mara and Parse
  2. Parse plays Buffer Overflow.
  3. Mara plays Wand of Banishment
  4. When villain plays a card, discard it with Buffer Overflow.
  5. When Buffer Overflow would destroy itself, use Wand of Banishment to place it on the bottom (or top) of Parse's deck instead.
  6. Replay that Buffer Overflow (easy to replay from the bottom of Parse's deck if you're using her variant).
  7. Watch as future villain cards are played without Buffer Overflow activating.

Expected behavior A replayed Buffer Overflow should work the same as if it had never been hit by Wand of Banishment.

Screenshots If applicable, add screenshots to help explain your problem. 20230704142359_1 20230704142404_1

20230704142407_1 20230704143211_1 20230704143222_1 20230704143626_1

Additional context I tested Buffer Overflow with Fixed Point in play, and Buffer Overflow successfully discarded multiple villain cards per turn all while never being destroyed. Buffer Overflow also worked after being recycled by La Comodora. This definitely looks like a Mara bug and not a general Buffer Overflow bug.

origamiswami commented 8 months ago

I was able to replicate the bug, and I also found that if you try the same thing with Knyfe's Focusing Conduit Blade, after getting re-played and then destroyed again, the post-destroy effect of Conduit Blade is activated twice! It seems like Wand of Banishment does something weird to cards that use AddAfterDestroyedAction() but I don't know why yet. I also don't know why Buffer Overflow didn't react to villain cards being played, but the damage increase effect from Conduit Blade still worked correctly after being re-played.