Sotera / GEQE

Geo Event Quey by Example - Leverage geo-located temporal text data in order to identify similar locations or events.
http://sotera.github.io/GEQE
The Unlicense
8 stars 7 forks source link

accidental delete of polyset data #42

Open eric-kimbrel opened 9 years ago

eric-kimbrel commented 9 years ago

It is very easy to accidentally delete the data from a polyset by clicking the edit button when the screen is cleared. This is particularly easy to do if you are used to using the old UI where you would click to the pencil icon to draw the selected polygon. If I forgot about the change to the UI and use the system the old way I delete things by mistake. I believe the code works as intended, but I am calling this a bug from the usability standpoint.

suggested fix:

when the edit button is clicked the currently selected polygon should be drawn on the screen if not already drawn.

steps to reproduce:

  1. save a new poly set, and add a site to it (draw a square)
  2. with the polyset selected and on the screen click the * symbol at the upper right hand side of the control panel to clear the map
  3. click the edit button to turn on edit mode
  4. click the edit button again to turn off edit mode

expected: you didn't change the polygon, so it should be unchanged in the system actual: the polyset still exists, but the square (site) you added has been deleted from it.

eric-kimbrel commented 9 years ago

Additionally, the tooltip for the edit button still says " Draw polygon to the map" which is incorrect and also needs fixed to match current functionality.