Sotera / watchman

Watchman: An open-source social-media event-detection system
GNU General Public License v2.0
20 stars 7 forks source link

Add domain-name clustering service #100

Closed kenglish-pfi closed 7 years ago

kenglish-pfi commented 7 years ago

Add domain-name clustering service.

kenglish-pfi commented 7 years ago

That was a pattern started by Justin when we were running individual services locally under the debugger. The original code did not use a local variable and referenced: job['query_url']

You are right in that: query_url = os.getenv('QUERY_URL', job['query_url']) is clearer than: query_url = os.environ['QUERY_URL'] if 'QUERY_URL' in os.environ else job['query_url']