SoulUseless / pe

0 stars 0 forks source link

Deletion of a module does not check for assignments #10

Open SoulUseless opened 3 years ago

SoulUseless commented 3 years ago

Given that a module might contain information about other important things (specific assignments), and how modules can be named very similarly to each other (e.g. SOC CS 210X mods), implementing a blanket delete of the module with the specified name might be dangerous for a user as a small typo error could cause the loss of the entirety of a module's information that the user might not have wanted to delete.

This could be improved by either adding a verification prior to the deletion operation, or include a check to verify if all assignments under that module is completed/deleted, in order to reduce the chances of accidental deletion

nus-pe-bot commented 3 years ago

Team's Response

This would only be a complementing feature that we can improve in the future but this will not be considered a bug in our product and it does not affect any of our other features.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]