search

SoulWallet / soul-wallet-contract

core contract of eip 4337 implementation
275 stars 87 forks source link

Custom errors in SmartWallet.sol #10

Open proxima424 opened 2 years ago

proxima424 commented 2 years ago

I was just wondering if there is a specific reason to not use custom errors here. If not, can I implement it and raise a PR?

proxima424 commented 2 years ago

@zhangshengjie

jayden-sudo commented 2 years ago

Thank you,it is welcome to submit to branch-upgradable (this is the branch we will use), and the contract is indeed not optimized (currently only the PoC version), Note: I've been thinking about bundler in the last few days, sorry I didn't see your issue right away, if you want any discuss, you can join our group: https://t.me/+ok9IIpMeXFYwODBl 😃 (of course it is good on github too)