search

SoundMetrics / aris-integration-sdk

SDK for building custom controllers for the ARIS sonar.
MIT License
5 stars 2 forks source link

Release zip and tarball missing ARIS File SDK. #26

Closed fvasquez closed 7 years ago

fvasquez commented 7 years ago

The reorder-frame sample depends on the ARIS File SDK. I added the ARIS File SDK to this repo as a Git submodule for that reason. Unfortunately, submodules are not included in the .zip and tar.gz downloads created by GitHub for releases. The extracted aris-file-sdk directory is empty so the reorder-frame sample will not build out of the box. Consumers can probably bring the ARIS File SDK files back by issuing git submodule update --recursive but how would they know that.

fvasquez commented 7 years ago

Issuing git submodule update --recursive is not a workaround for this issue because files extracted from the download are "[n]ot a git repository". There is no .git directory included.

curtnichols commented 7 years ago

Investigate--known issue with github?