search

SoundMetrics / aris-integration-sdk

SDK for building custom controllers for the ARIS sonar.
MIT License
5 stars 2 forks source link

Set focus by range rather than "focus position." #3

Closed curtnichols closed 8 years ago

curtnichols commented 8 years ago

I'm thinking about extending SetFocusPosition to take a range in meters; this is more natural for integration partners and prevents exposure to focus mapping. The 'position' field would continue to be supported by the firmware, but if 'focusRange' is present in the command then range will be used instead. ARIScope will continue to use 'position' in support of older firmware.

Let me know what you think.

curtnichols commented 8 years ago

Note that setting acoustic settings will remain unchanged for now. It seems intuitive to say "let's do the same for acoustic settings," but to choose good acoustic settings one really needs to know the details of it, so I don't see changing that anytime soon.

fvasquez commented 8 years ago

I suspect many integrators are already mapping range in meters to focus units linearly. I agree that we want to hide the existing focus maps from them. They just complicate the API. If we care about the level of precision focus maps give us then the firmware should probably deal with them. When you say "firmware" I assume you mean the sonar software and arisapp in particular. While I'm averse to adding more code to arisapp that is obviously where the focus maps need to go if we add focusRange to the command protocol.