Fix a couple more 64-bit warnings.

SoundMetrics / aris-integration-sdk

SDK for building custom controllers for the ARIS sonar.

MIT License

5 stars 2 forks source link

Fix a couple more 64-bit warnings. #50

Closed fvasquez closed 7 years ago

fvasquez commented 7 years ago

I only fixed warnings in our code. x64 Release build of arislog still fails because of conversion from 'size_t' to 'int' warnings in code generated by protoc.

curtnichols commented 7 years ago

The generated code is compiled with /W3 to avoid the bulk of the warnings. We'll have to turn off 'warnings as errors' if we were to build the 64-bit target, which I'm game for.

Of course, it strangely doesn't build on my machine, so I can't catch everything right now.

curtnichols commented 7 years ago

Found my build problem, for some reason the protobuf submodule hadn't populated, though the aris-file-sdk submodule had....

fvasquez commented 7 years ago

arislog Release x64 is closer to building but now fails with a linker error.

Error LNK1112 module machine type 'X86' conflicts with target machine type 'x64' arislog C:\Users\Frank\Documents\GitHub\aris-integration-sdk\tools\arislog\arislog\libprotobuf.lib

This error could be unique to my environment. Not sure what version of protobuf I installed.