SoundScapeRenderer / ssr

Main source code repository for the SoundScape Renderer
http://spatialaudio.net/ssr/
GNU General Public License v3.0
134 stars 53 forks source link

Pd externals are built with `-mmacosx-version-min=10.15` instead of `10.9` #374

Closed mgeier closed 5 months ago

mgeier commented 1 year ago

It was brought up in the Pd mailing list that the Externals (installed via Deken) don't work on macOS 10.14 (Mojave).

We intended to use version 10.9 in our CI settings:

https://github.com/SoundScapeRenderer/ssr/blob/1c6c0b3e2b113c928687527abcfad04502f009a7/.github/workflows/pd-externals.yml#L45

However, this seems to be overruled by -mmacosx-version-min=10.15 for some reason, see for example this log: https://github.com/SoundScapeRenderer/ssr/actions/runs/5489496909/job/14867315885

Any ideas how to fix this?

We probably don't need as old a version as 10.9, but at least 10.14 still seems to be used.

Lucarda commented 1 year ago

Hi,

it seems to come from here :

https://github.com/SoundScapeRenderer/ssr/blob/1c6c0b3e2b113c928687527abcfad04502f009a7/flext/Makefile?plain=1#L17

mgeier commented 1 year ago

Oh wow, thanks @Lucarda! I made that change myself, and then I completely forgot about it.

It turns out that I originally switched to 10.15 because this is the first version to support std::filesystem.

I have created #375 to remove the use of std::filesystem and to go back to a minimum version of 10.9.

mgeier commented 5 months ago

It turns out that this doesn't work within the brew ecosystem, see #375.

I have removed the ineffective setting in #388.

I don't think there is anything else that I can reasonably do, but if there is, please let me know!