search

SoundScapeRenderer / ssr

Main source code repository for the SoundScape Renderer
http://spatialaudio.net/ssr/
GNU General Public License v3.0
132 stars 52 forks source link

Improve Qt5 linking on macOS #381

Closed HaHeho closed 6 months ago

HaHeho commented 8 months ago

I think this is cleaner to temporarily link Qt5 from homebrew when Qt6 is also installed, with the main reason that the brew link configuration does not need to be corrected and reverted to Qt6 after building.

The GitHub Actions currently fail due to an outdated macOS+Xcode configuration as described in https://github.com/SoundScapeRenderer/ssr/issues/380. I've manually rerun a newer configuration, which was built successfully.

mgeier commented 8 months ago

Thanks! This looks good to me, can you please rebase? Now CI should pass.

HaHeho commented 8 months ago

Thanks! This looks good to me, can you please rebase? Now CI should pass.

Done. Everything passed.

mgeier commented 7 months ago

Sorry, can you please re-base again?

Some commits are now already in the master branch, so they should be removed here.

HaHeho commented 6 months ago

Sorry, can you please re-base again?

Some commits are now already in the master branch, so they should be removed here.

Not sure what happened there. Rebased now against latest and all tests pass.

mgeier commented 6 months ago

Thanks!