macOS: Use native 'fullscreen' rather than 'maximize'

[0xdevalias]

Currently pressing the 'green plus' button causes the window to expand to maximize the full 'current' screen. Most macOS applications these days have a 'green diagonal arrow' button instead of this, which makes the window an 'actual' full screen / separate 'space'.

It would be great if that was supported in soundnode, it's my one major annoyance right now.

Reading a little deeper into electron's browser-window, it looks like these settings may be relevant:

• fullscreen Boolean (optional) - Whether the window should show in fullscreen. When explicitly set to false the fullscreen button will be hidden or disabled on macOS. Default is false.
• fullscreenable Boolean (optional) - Whether the window can be put into fullscreen mode. On macOS, also whether the maximize/zoom button should toggle full screen mode or maximize window. Default is true.
• simpleFullscreen Boolean (optional) - Use pre-Lion fullscreen on macOS. Default is false.

It sounds as though you may only be able to have one of the 'maximize' or 'fullscreen' options enabled at the same time, so perhaps adding which to use as a value in the settings screen would be good to allow people to choose.

[etaletai13]

@0xdevalias It sounds like you should probably take a crack at this one, since you've researched it! It's a simple one, right in the menu definition and you'll want fullscreenable it sounds like for electron.BrowserWindow

[0xdevalias]

Even though it should be a simple change, unfortunately I don't have the capacity to take on new projects at this stage (particularly with getting the codebase/dev environment set up, testing, etc)

[etaletai13]

@0xdevalias Try out pull #1081