search

Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜
MIT License
100 stars 21 forks source link

Champion select bar stuck in loading #133

Open OMalenfantThuot opened 1 year ago

OMalenfantThuot commented 1 year ago

This is a weird issue.

I installed today's update and the champion search bar stopped working. Now the waiting circle is just spinning non stop. The "Auto select" button is stuck as well, but the rest of the application is working (of course I'm not getting any rune page as I can't select a champion).

I tried completely uninstalling and resintalling the older version, which was working well before the update and the problem persists, so it's probably not related directly to the last PR.

If anyone has an idea of what could cause this, that'd be great. Thanks!

Denidil commented 1 year ago

I am also experiencing the same problem

Soundofdarkness commented 1 year ago

Hm, that is really weird yeah. I'm going to take a look when I have time, but I'm going to assume that maybe something changed on riots end then. Hopefully that's fixable and not something along the lines of them locking down the LCU-Api due to people reading out player names in ranked...

OMalenfantThuot commented 1 year ago

Thanks! Btw, I'm pretty sure it is stuck in the "Do not auto select position" if it makes a difference.

image

Denidil commented 1 year ago

The HTTPS certificate for ddragon.leagueoflegends.com seems to have expired. Now you have three options:

* wait until the certificate is renewed

* use HTTP instead of HTTPS for all "ddragon.leagueoflegends.com" (problem solved)

* add something to ignore certificate errors

I noticed that on metasrc itself too.. images weren't loading.

I would suggest a few things to fix Runebook here

A) institute a timeout, instead of jamming the UI, if one of the build providers fails

B) prompt to ask if falling back to HTTP is acceptable when HTTPS fails ("yes", "no" + "don't ask again" checkmark [default on])

Denidil commented 1 year ago

Related issue: https://github.com/RiotGames/developer-relations/issues/591

Denidil commented 1 year ago

They've renewed the certificate

OMalenfantThuot commented 1 year ago

Yes it's working now. Thanks! This might happen again every year, so your suggestions still makes sense.

Soundofdarkness commented 1 year ago

Nice to hear its working again! About the cert part, I will take a look on that when I have time but it might be difficult to fix that without having to hope that stale data is still fine. One way might be to fallback to cdragon too...