search

Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜
MIT License
100 stars 21 forks source link

Fix undefined page on blitz plugin #136

Closed Neylix closed 1 year ago

Neylix commented 1 year ago

Fixes #135

Hello ! Here is a fix for the blitz.gg plugin. There is a bug when there is no page fetched for a game mode and a role (i.e. Ahri jungle in ranked mode). It creates an undefined key => value in the runePages object which lead to this error :

image

The fix is to return a null value when no page is fetched and add only non null value in the runePages object

Soundofdarkness commented 1 year ago

Hey, apologies for the extremely late reply, I will try to take a look at the PR in the next few days and hopefully release it.

Soundofdarkness commented 1 year ago

Alright, looks good to me. Thank you ! Going to hopefully release the fix later today :)