Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜
MIT License
100 stars 21 forks source link

Auto-upload favorite local page #41

Closed TinyRaindrop closed 4 years ago

TinyRaindrop commented 4 years ago

Resolves #38

  1. [x] Has settings switch.
  2. [x] When enabled, adds fav buttons and you can set one local page as favorite.
  3. [x] In champ select, after locking in, this page will be uploaded if current champs matches the one you picked.
  4. [x] new strings added to all locales.

Obviously, needs some testing (practice tool lobby works great).

Anyone can test this pull request:

git remote add upstream https://github.com/Soundofdarkness/RuneBook.git
git fetch upstream pull/41/head:favpage
git checkout favpage

This creates local branch 'favpage'

12_57-RuneBook

Soundofdarkness commented 4 years ago

Looks pretty good so far, I'm just going to wait with merging this one until the theme stuff is stable, so we can test it on a clean version.

TinyRaindrop commented 4 years ago

All done here

Soundofdarkness commented 4 years ago

Yup, works great, thanks for the nice feature :)