search

Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜
MIT License
100 stars 21 forks source link

Reorder / rename local pages #6

Open TinyRaindrop opened 4 years ago

TinyRaindrop commented 4 years ago

Original issue here

Right now there's no way of managing local pages apart from uploading them to client, modifying there, and saving again, which puts the page on the last place.

Would be nice to be able to reorder them, maybe rename too (latter is not a priority for me).

TinyRaindrop commented 4 years ago

Maybe stupid idea, but currently reordering pages is a minigame of its own.

Dragging can be implemented using SortableJS, for instance, or even manually, using HTML5 features. But how would I go about saving and restoring the order of pages? Pages are not saved in arrays, but rather in objects.

One way I can think of is putting numeric "index" key into each local page and kind of sort the pages by shuffling these keys, then feed the sorted thing into pagelist.tag (not sure how exactly)? Is there a simple way I'm not seeing here?

jeske commented 4 years ago

Agreed.. though honestly, I'd be happy if I could just rename them in RuneBook...

Turb0Hawk commented 2 years ago

Hey guys im working oin this feature and i just want to know, are we ok with using external packages/libraries for stuff like prompt windows ? electron does not support the classic js prompt(message, defaultValue).......

TinyRaindrop commented 2 years ago

@Turb0Hawk Runebook uses SemanticUI CSS framewok, which has plenty of JS stuff in it. Modals are might be what you're looking for. Check out this modal example.

Turb0Hawk commented 2 years ago

thanks bud ! this is my first node/js project since HS sooooo im rusty and lost. I work front/back end in c# so all the help is appreciated