search

Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜
MIT License
103 stars 22 forks source link

dont use jquery for external links #92

Closed ghost closed 3 years ago

ghost commented 3 years ago

The old variant needs JQuery and because I want to remove JQuery (currently "semantic-ui-css" is still the blocker, but there it will be worked on (or you could switch to "fomantic-ui-css" if they are faster).

But anyway. This PR removes the old variant and replaces it with a better one that has no dependency.

Remark: external URL's must contain target="_blank.

Soundofdarkness commented 3 years ago

Yup, removing Jquery sounds like a good idea to me to. Wont be able to test this one either atm (same as #91 ), but will already merge it since its nothing that needs to be hotfix-released atm anyways. Thanks !