Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜
MIT License
100 stars 21 forks source link

Error when opening runebook before League #98

Closed SandersAaronD closed 1 year ago

SandersAaronD commented 3 years ago

image

Pretty simple; if you open this before League, this happens. I assume when this app initializes itself it's grabbing either the lockfile or some of the config, and it's being locked or held open in a way that the Riot or League client doesn't approve of so the League client is failing to initialize itself correctly.

I'll look at putting in a PR for this but am unsure if it's going to happen.

In a tertiary way: I'd be curious what guidelines for contributing here look like.

Soundofdarkness commented 3 years ago

Hey, honestly I'm pretty sure that the issue was just related to the league client alone. I've opened the league client several times after runebook and I've never had any issues. Not to mention that, as far as I'm aware, we don't even automatically open the lock file, rather just on pressing the refresh button and we neither keep a lock on it.

For now I'm going to leave this open in case more people experience your issue and would then look into it again. If you have any additional info I will take a look again too !