search

SourMesen / Mesen-S

Mesen-S is a cross-platform (Windows & Linux) SNES emulator built in C++ and C#
GNU General Public License v3.0
414 stars 102 forks source link

Tile Viewer colors differ from actual palette #120

Closed SuperLuigiLinked closed 4 years ago

SuperLuigiLinked commented 4 years ago

I was analyzing the tiles in F-ZERO and noticed an odd inconsistency. Here's an example:

Let's examine the Dark Color from the energy barrier tiles: image image The hex code color is listed as 217B39 in the Palette Viewer.

If I take a screenshot of the game and use the dropper tool to get the color: image image It says 217B39, which is the same as the Palette Viewer.

The oddity comes in when I use the dropper tool on the tile in the Tile Viewer: image This time, what should be the same color from the same tile shows up as 207838.

This slight color inconsistency is true for the other colors in the Tile Viewer as well. I would believe that it was just the result of some settings on my display if it weren't for the fact that the colors on the Game Window are consistent with the Palette Viewer, but not the Tile Viewer.

This difference seems to be unintentional, so I'm reporting it.

SourMesen commented 4 years ago

Thanks! This was caused by an older version of the 15-bit to 24-bit color conversion logic still being used by the ppu viewers, while the rest used the correct formulas.

This is fixed in the latest commit.