search

SourMesen / Mesen

Mesen is a cross-platform (Windows & Linux) NES/Famicom emulator built in C++ and C#
https://www.mesen.ca
GNU General Public License v3.0
1.25k stars 317 forks source link

Integrate this NES 2.0 Header database into the emulator. #808

Closed Yersho closed 4 years ago

Yersho commented 4 years ago

https://forums.nesdev.com/viewtopic.php?f=3&t=19940 (Database in question). This should definitely add more compatibility with headerless NES ROMs and let people who don't know how to make a header or people who can't find specific info (PRG ROM size, CHR ROM size, Save RAM size, etc.) have more user friendly compatiblity.

SourMesen commented 4 years ago

Thanks for the request. This is already done as of this commit a few days ago: 77e04a679e713fdcf78d517d4efda987a236412f

Yersho commented 4 years ago

Oh, my bad. Now that there is a near complete NES 2.0 header database integrated into Mesen do you think it would be possible for you to maintain a updated header database from now on? (Sorry for asking a question in a closed issue I just feel I shouldn't waste your time with a brand new issue asking this.)

SourMesen commented 4 years ago

No, I don't plan on maintaining the DB myself. As far as I can tell, NewRisingSun is planning on keeping it up-to-date since it's relatively easy for him to generate it from a set of ROMs he has. I will be re-updating the embedded DB in Mesen when NRS updates his database as time goes on, but won't be maintaining it as a separate thing (I simply don't have the time to do this on top of everything else)

Yersho commented 4 years ago

Oh ok, I understand. As long as the database is properly maintained somewhere I'm fine with it.