search

Source-Python-Dev-Team / Source.Python

This plugin aims to use boost::python and create an easily accessible wrapper around the Source Engine API for scripter use.
http://forums.sourcepython.com
GNU General Public License v3.0
163 stars 31 forks source link

Re-Iteration of the Offset in CCSPlayer offsets. (CSGO) #388

Closed Grubbsy1896 closed 3 years ago

Grubbsy1896 commented 3 years ago

MVP, Kills, Assists, and such all have updated offsets, at least from the current ones listed.

addons/source-python/data/source-python/entities/csgo/CCSPlayer.ini

image

CookStar commented 3 years ago

These offsets are no longer needed by 9d6c9e07b95cc6eef900c69dc5220d3682e7c2d1. It's been off by almost a month, but there doesn't seem to be any problem.

jordanbriere commented 3 years ago

It's been off by almost a month, but there doesn't seem to be any problem.

If servers are running an updated SP build then the based_attribute are being prioritized, but for those that aren't they are still using the instance_attribute (which was the reason they were left in the file, so that live servers don't pull a data update removing attributes until they update their whole installation). However, if the instance_attribute are no longer valid, then they can now be removed and it is time for servers to update if they didn't.

Just one thing before I get that merged in, are the based_attribute confirmed to still be valid?

Thanks!

CookStar commented 3 years ago

If servers are running an updated SP build then the based_attribute are being prioritized, but for those that aren't they are still using the instance_attribute (which was the reason they were left in the file, so that live servers don't pull a data update removing attributes until they update their whole installation). However, if the instance_attribute are no longer valid, then they can now be removed and it is time for servers to update if they didn't.

Oh yes, I had forgotten about those who have not updated their Source.Python. I probably should have deleted it much earlier.

Just one thing before I get that merged in, are the based_attribute confirmed to still be valid?

Yes.