search

SourceHorizon / logger

Small, easy to use and extensible logger which prints beautiful logs.
https://pub.dev/packages/logger
MIT License
197 stars 33 forks source link

Add file deletion options for rotated files #71

Closed lomby92 closed 4 months ago

lomby92 commented 4 months ago

Closes #70

lomby92 commented 4 months ago

If you need any explanation on the implementation, feel free to reach me out

Bungeefan commented 4 months ago

Hi, thanks for the offer! Sorry for the delay in reviewing, I had a quite busy week, will do it ASAP.

Bungeefan commented 4 months ago

Your tests seem to be kind of flaky, especially on GitHub Actions :thinking:

Bungeefan commented 4 months ago

That's quite interesting. After some tests on my part, I found that the only test that is flaky on my machine is the "custom file sorter" (fixable with a small timeout, probably because of file system flush) but for GitHub Actions it seems like it's only struggling with the regular "files deletion" one. I can't really reproduce this on my side yet...

lomby92 commented 4 months ago

Really interesting since i didn't encountered problems during development.

OS: Fedora Linux Kernel: 6.8.7-100 Flutter: 3.19.5 Dart: 3.3.3

Bungeefan commented 4 months ago

After some tests with my private Jenkins (where I could reproduce the GitHub Actions failures), I found out that 1000ms seem to be minimal sleep duration that doesn't trigger any flakiness in the test.

I still want to find out why there is such a flakiness even with some sleep steps in the test, however, as this doesn't seem to be a problem in your code and shouldn't impact any users, I will no longer delay the release of 2.3.0.

logger v2.3.0 has been successfully published on pub.dev!