Task description should preserve white space

[patrickmcsweeney]

Current when you edit task descriptions in the edit window they are plain text with line breaks. When they are rendered some attempt seems to be made to break them up into paragraphs. In practice this doesnt work hugely well. A far more effective solution would be to style the element to preserve whitespace. When this is done the central alignment becomes much more obvious and looks a bit wrong. I suggest .task-description-text { white-space: pre-wrap; text-align: left; }

[antineutron]

It's actually using MarkDown to parse it (in some bizarre fashion), so you can do things like:

• Bullet
• points

It does seem to be centering the text though, maybe doing text-align: left would help by itself?

[antineutron]

the task "card" view is still a bit shonky and could use some UI loving tbh.

[patrickmcsweeney]

Ok i didnt know that. Text align left would be a win and ill pass the other knowing on to people.

On Wed, May 20, 2015 at 5:48 PM, Andy Newton notifications@github.com wrote:

the task "card" view is still a bit shonky and could use some UI loving tbh.

— Reply to this email directly or view it on GitHub https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103956216 .

'But your intentions are beside the point, It's the outcome of your actions that count...'

[antineutron]

Playing around with the alignment, I can't find anything that looks not-wrong (either it's centred and the text looks wrong, or it's left-aligned and the whole thing looks a bit off). Might see if it looks any better with a border, or something.

On 20/05/2015 18:00, Patrick McSweeney wrote:

Ok i didnt know that. Text align left would be a win and ill pass the other knowing on to people.

On Wed, May 20, 2015 at 5:48 PM, Andy Newton notifications@github.com wrote:

the task "card" view is still a bit shonky and could use some UI loving tbh.

— Reply to this email directly or view it on GitHub

https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103956216 .

'But your intentions are beside the point, It's the outcome of your actions that count...'

— Reply to this email directly or view it on GitHub https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103960273.Web Bug from https://github.com/notifications/beacon/AAdY-ubm95rOjIfer0v-m11KReIpHo9kks5oLLU4gaJpZM4EhycN.gif

[antineutron]

have a look on sourcekettle-test

On 20/05/2015 18:00, Patrick McSweeney wrote:

Ok i didnt know that. Text align left would be a win and ill pass the other knowing on to people.

On Wed, May 20, 2015 at 5:48 PM, Andy Newton notifications@github.com wrote:

the task "card" view is still a bit shonky and could use some UI loving tbh.

— Reply to this email directly or view it on GitHub

https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103956216 .

'But your intentions are beside the point, It's the outcome of your actions that count...'

— Reply to this email directly or view it on GitHub https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103960273.Web Bug from https://github.com/notifications/beacon/AAdY-ubm95rOjIfer0v-m11KReIpHo9kks5oLLU4gaJpZM4EhycN.gif

[patrickmcsweeney]

Not on VPN currently but ill take a look. One thing that does occur to me is the main time is a nuisence is when we copy requirements out of email. Usually those arent sent in mark down. I will play about with the test and show the others mark down and see where we get to.

Pat

On Wed, May 20, 2015 at 6:07 PM, Andy Newton notifications@github.com wrote:

have a look on sourcekettle-test

On 20/05/2015 18:00, Patrick McSweeney wrote:

Ok i didnt know that. Text align left would be a win and ill pass the other knowing on to people.

On Wed, May 20, 2015 at 5:48 PM, Andy Newton notifications@github.com wrote:

the task "card" view is still a bit shonky and could use some UI loving tbh.

— Reply to this email directly or view it on GitHub

< https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103956216

.

'But your intentions are beside the point, It's the outcome of your actions that count...'

— Reply to this email directly or view it on GitHub < https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103960273>.Web

Bug from

https://github.com/notifications/beacon/AAdY-ubm95rOjIfer0v-m11KReIpHo9kks5oLLU4gaJpZM4EhycN.gif

— Reply to this email directly or view it on GitHub https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103963283 .

'But your intentions are beside the point, It's the outcome of your actions that count...'

[antineutron]

If you can ping me an example of something that looks wonky that'd help. Markdown's usually pretty unobtrusive but it can do irritating things sometimes (see also: any other markup format!)

It's a bit of a mess, could really do with deshonkifying. Making the markdown (or equivalent) a client-side thing would help.

On 20/05/2015 18:24, Patrick McSweeney wrote:

Not on VPN currently but ill take a look. One thing that does occur to me is the main time is a nuisence is when we copy requirements out of email. Usually those arent sent in mark down. I will play about with the test and show the others mark down and see where we get to.

Pat

On Wed, May 20, 2015 at 6:07 PM, Andy Newton notifications@github.com wrote:

have a look on sourcekettle-test

On 20/05/2015 18:00, Patrick McSweeney wrote:

Ok i didnt know that. Text align left would be a win and ill pass the other knowing on to people.

On Wed, May 20, 2015 at 5:48 PM, Andy Newton notifications@github.com wrote:

the task "card" view is still a bit shonky and could use some UI loving tbh.

— Reply to this email directly or view it on GitHub

<

https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103956216

.

'But your intentions are beside the point, It's the outcome of your actions that count...'

— Reply to this email directly or view it on GitHub <

https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103960273>.Web

Bug from

https://github.com/notifications/beacon/AAdY-ubm95rOjIfer0v-m11KReIpHo9kks5oLLU4gaJpZM4EhycN.gif

— Reply to this email directly or view it on GitHub

https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103963283 .

'But your intentions are beside the point, It's the outcome of your actions that count...'

— Reply to this email directly or view it on GitHub https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103967384.Web Bug from https://github.com/notifications/beacon/AAdY-hhoXC2ul1fDVwSjpaLT_2vsNyQ8ks5oLLrFgaJpZM4EhycN.gif

[patrickmcsweeney]

https://sourcekettle.ecs.soton.ac.uk/project/practiceplacements/tasks/view/78

On Wed, May 20, 2015 at 6:30 PM, Andy Newton notifications@github.com wrote:

If you can ping me an example of something that looks wonky that'd help. Markdown's usually pretty unobtrusive but it can do irritating things sometimes (see also: any other markup format!)

It's a bit of a mess, could really do with deshonkifying. Making the markdown (or equivalent) a client-side thing would help.

On 20/05/2015 18:24, Patrick McSweeney wrote:

Not on VPN currently but ill take a look. One thing that does occur to me is the main time is a nuisence is when we copy requirements out of email. Usually those arent sent in mark down. I will play about with the test and show the others mark down and see where we get to.

Pat

On Wed, May 20, 2015 at 6:07 PM, Andy Newton notifications@github.com wrote:

have a look on sourcekettle-test

On 20/05/2015 18:00, Patrick McSweeney wrote:

Ok i didnt know that. Text align left would be a win and ill pass the other knowing on to people.

On Wed, May 20, 2015 at 5:48 PM, Andy Newton notifications@github.com wrote:

the task "card" view is still a bit shonky and could use some UI loving tbh.

— Reply to this email directly or view it on GitHub

<

https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103956216

.

'But your intentions are beside the point, It's the outcome of your actions that count...'

— Reply to this email directly or view it on GitHub <

https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103960273 .Web

Bug from

https://github.com/notifications/beacon/AAdY-ubm95rOjIfer0v-m11KReIpHo9kks5oLLU4gaJpZM4EhycN.gif

— Reply to this email directly or view it on GitHub

< https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103963283

.

'But your intentions are beside the point, It's the outcome of your actions that count...'

— Reply to this email directly or view it on GitHub < https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103967384>.Web

Bug from

https://github.com/notifications/beacon/AAdY-hhoXC2ul1fDVwSjpaLT_2vsNyQ8ks5oLLrFgaJpZM4EhycN.gif

— Reply to this email directly or view it on GitHub https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103968941 .

'But your intentions are beside the point, It's the outcome of your actions that count...'

[antineutron]

Ouch, that's pretty crap. I think markdown treats \n\n as "start new paragraph", but a single \n seems to just get swallowed. Quick fix would be "prefix lines with * " to get the bullet point effect but not ideal if it's been copy-pasted from an email. Hmm.

Possible shitty hack: s/\n[^\n]/
/g (note, needs improvement to avoid

foo

nonsense) On 20/05/2015 19:44, Patrick McSweeney wrote: > https://sourcekettle.ecs.soton.ac.uk/project/practiceplacements/tasks/view/78 > > On Wed, May 20, 2015 at 6:30 PM, Andy Newton notifications@github.com > wrote: > > > If you can ping me an example of something that looks wonky that'd help. > > Markdown's usually pretty unobtrusive but it can do irritating things > > sometimes (see also: any other markup format!) > > > > It's a bit of a mess, could really do with deshonkifying. Making the > > markdown (or equivalent) a client-side thing would help. > > > > On 20/05/2015 18:24, Patrick McSweeney wrote: > > > > > Not on VPN currently but ill take a look. One thing that does > > > occur to me > > > is the main time is a nuisence is when we copy requirements out of > > > email. > > > Usually those arent sent in mark down. I will play about with the test > > > and > > > show the others mark down and see where we get to. > > > > > > Pat > > > > > > On Wed, May 20, 2015 at 6:07 PM, Andy Newton > > > notifications@github.com > > > wrote: > > > > > > > have a look on sourcekettle-test > > > > > > > > On 20/05/2015 18:00, Patrick McSweeney wrote: > > > > > > > > > Ok i didnt know that. Text align left would be a win and ill > > > > > pass the > > > > > other > > > > > knowing on to people. > > > > > > > > > > On Wed, May 20, 2015 at 5:48 PM, Andy Newton > > > > > notifications@github.com > > > > > wrote: > > > > > > > > > > > the task "card" view is still a bit shonky and could use some UI > > > > > > loving > > > > > > tbh. > > > > > > > > > > > > — > > > > > > Reply to this email directly or view it on GitHub > > > > > > > > > > > > < > > > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103956216 > > > > > > > > . > > > > > > > > > > ## > > > > > > > > > > 'But your intentions are beside the point, It's the outcome of > > > > > your > > > > > actions > > > > > that count...' > > > > > > > > > > — > > > > > Reply to this email directly or view it on GitHub > > > > > < > > > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103960273 > > > > > .Web > > > > > > > > Bug from > > > > https://github.com/notifications/beacon/AAdY-ubm95rOjIfer0v-m11KReIpHo9kks5oLLU4gaJpZM4EhycN.gif > > > > > > — > > > > Reply to this email directly or view it on GitHub > > > > > > > > < > > > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103963283 > > > > > > . > > > > > > ## > > > > > > 'But your intentions are beside the point, It's the outcome of your > > > actions > > > that count...' > > > > > > — > > > Reply to this email directly or view it on GitHub > > > < > > > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103967384>.Web > > > > > Bug from > > > > https://github.com/notifications/beacon/AAdY-hhoXC2ul1fDVwSjpaLT_2vsNyQ8ks5oLLrFgaJpZM4EhycN.gif > > > > > > — > > Reply to this email directly or view it on GitHub > > > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103968941 > > . > > ## > > 'But your intentions are beside the point, It's the outcome of your > actions > that count...' > > — > Reply to this email directly or view it on GitHub > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103991213.Web > Bug from > https://github.com/notifications/beacon/AAdY-k0lj_lR1beBza17CXY8f4AxUKC1ks5oLM14gaJpZM4EhycN.gif

[patrickmcsweeney]

I can put stars on the front its fine. no need to mess with it.

On Wed, May 20, 2015 at 7:49 PM, Andy Newton notifications@github.com wrote:

Ouch, that's pretty crap. I think markdown treats \n\n as "start new paragraph", but a single \n seems to just get swallowed. Quick fix would be "prefix lines with * " to get the bullet point effect but not ideal if it's been copy-pasted from an email. Hmm.

Possible shitty hack: s/\n[^\n]/
/g (note, needs improvement to avoid

foo

nonsense) On 20/05/2015 19:44, Patrick McSweeney wrote: > https://sourcekettle.ecs.soton.ac.uk/project/practiceplacements/tasks/view/78 > > On Wed, May 20, 2015 at 6:30 PM, Andy Newton notifications@github.com > wrote: > > > If you can ping me an example of something that looks wonky that'd > > help. > > Markdown's usually pretty unobtrusive but it can do irritating things > > sometimes (see also: any other markup format!) > > > > It's a bit of a mess, could really do with deshonkifying. Making the > > markdown (or equivalent) a client-side thing would help. > > > > On 20/05/2015 18:24, Patrick McSweeney wrote: > > > > > Not on VPN currently but ill take a look. One thing that does > > > occur to me > > > is the main time is a nuisence is when we copy requirements out of > > > email. > > > Usually those arent sent in mark down. I will play about with the > > > test > > > and > > > show the others mark down and see where we get to. > > > > > > Pat > > > > > > On Wed, May 20, 2015 at 6:07 PM, Andy Newton > > > notifications@github.com > > > wrote: > > > > > > > have a look on sourcekettle-test > > > > > > > > On 20/05/2015 18:00, Patrick McSweeney wrote: > > > > > > > > > Ok i didnt know that. Text align left would be a win and ill > > > > > pass the > > > > > other > > > > > knowing on to people. > > > > > > > > > > On Wed, May 20, 2015 at 5:48 PM, Andy Newton > > > > > notifications@github.com > > > > > wrote: > > > > > > > > > > > the task "card" view is still a bit shonky and could use some > > > > > > UI > > > > > > loving > > > > > > tbh. > > > > > > > > > > > > — > > > > > > Reply to this email directly or view it on GitHub > > > > > > > > > > > > < > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103956216 > > > > > > > . > > > > > > > > > > ## > > > > > > > > > > 'But your intentions are beside the point, It's the outcome of > > > > > your > > > > > actions > > > > > that count...' > > > > > > > > > > — > > > > > Reply to this email directly or view it on GitHub > > > > > < > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103960273 > > > > .Web > > > > > > > > Bug from > > https://github.com/notifications/beacon/AAdY-ubm95rOjIfer0v-m11KReIpHo9kks5oLLU4gaJpZM4EhycN.gif > > > > > — > > > > Reply to this email directly or view it on GitHub > > > > > > > > < > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103963283 > > > > > . > > > > > > ## > > > > > > 'But your intentions are beside the point, It's the outcome of your > > > actions > > > that count...' > > > > > > — > > > Reply to this email directly or view it on GitHub > > > < > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103967384 > .Web > > > > Bug from > > https://github.com/notifications/beacon/AAdY-hhoXC2ul1fDVwSjpaLT_2vsNyQ8ks5oLLrFgaJpZM4EhycN.gif > > > — > > Reply to this email directly or view it on GitHub > > > > < > > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103968941 > > > > . > > ## > > 'But your intentions are beside the point, It's the outcome of your > actions > that count...' > > — > Reply to this email directly or view it on GitHub > < > https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103991213>.Web > > Bug from > > https://github.com/notifications/beacon/AAdY-k0lj_lR1beBza17CXY8f4AxUKC1ks5oLM14gaJpZM4EhycN.gif — Reply to this email directly or view it on GitHub https://github.com/SourceKettle/sourcekettle/issues/473#issuecomment-103992421 .

'But your intentions are beside the point, It's the outcome of your actions that count...'