search

SourceKettle / sourcekettle

SourceKettle is an open source project management and source code management tool
17 stars 6 forks source link

Two accounts can have the same public key #483

Open patrickmcsweeney opened 8 years ago

patrickmcsweeney commented 8 years ago

Two accounts can have the same public key but when you go to push as with the key the first account in the database is always used. This means it is possible to create a repository which you can not push to. My suggested fix is check if a public key is already in use before adding it and tell the user accordingly. That should prevent it from ever happening.

antineutron commented 8 years ago

I think that was already a thing that got fixed. Possible that existing dupes weren't cleaned up though.

patrickmcsweeney commented 8 years ago

It may be that the fix is something we have not yet deployed on live. I will look at the code. Kev and Andy are looking at few things this week.

On Wed, Nov 2, 2016 at 11:55 AM, Andy Newton notifications@github.com wrote:

I think that was already a thing that got fixed. Possible that existing dupes weren't cleaned up though.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SourceKettle/sourcekettle/issues/483#issuecomment-257844103, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQJw3DAUdB4HH8klZTnoniD-hr3gONvks5q6HoogaJpZM4Kb5-C .

'But your intentions are beside the point, It's the outcome of your actions that count...'