search

SourceKettle / sourcekettle

SourceKettle is an open source project management and source code management tool
17 stars 6 forks source link

User settings should not be part of the users controller #88

Closed pwhittlesea closed 12 years ago

pwhittlesea commented 12 years ago

Currently we have URLS like:

http://localhost/devtrack/users/editdetails
http://localhost/devtrack/users/editpassword

Which looks really messy. I would suggest:

http://localhost/devtrack/users/editdetails -> http://localhost/devtrack/settings/details
http://localhost/devtrack/users/editpassword -> http://localhost/devtrack/settings/security

I know its a minor thing, but I think it would make DevTrack look less bodged.

pwhittlesea commented 12 years ago

@xycaleth Want to take this on as your first task? Would be a good mix of backend and front end?

xycaleth commented 12 years ago

Sure, why not.

pwhittlesea commented 12 years ago

Just to clarify, it would be best to actually move the functions to the settings controller (May involve importing the 'Users' model), not just set up routing aliases :P

xycaleth commented 12 years ago

Which of the links in the users sidebar do we want to link to /settings/pagename? At the moment, I'm doing edit details, edit password and edit theme. Do we want to change the delete account to something like, /settings/delete_account, and route the ssh keys from /users/sshkeys/xxx to /settings/sshkeys/xxx?

xycaleth commented 12 years ago

I ended up just renaming some of the actions, and re-routing some of the addresses to /account/xxx instead!