search

Sous-Chefs-Boneyard / mac_os_x

This cookbook has been deprecated
https://supermarket.chef.io/cookbooks/mac_os_x
Apache License 2.0
75 stars 25 forks source link

Makes it possible to set user in attributes #14

Closed jeroenj closed 11 years ago

jeroenj commented 11 years ago

This makes it possible to set the user who the default should be set for in the attributes hash:

node.default['mac_os_x']['settings']['finder'] = {
  "domain" => "com.apple.finder",
  "user" => "jeroen",
  "ShowStatusBar" => true
}
jeroenj commented 11 years ago

Any reason why this didn't got merged?

I'm not 100% ok with the code. I'd rather be able to set the user somewhere global so you don't have to repeat it for each setting. It also doesn't feel right to define user and domain on the same lever the preferences are defined.

jtimberman commented 11 years ago

Hi @jeroenj,

This is a cookbook I maintain in my free time. It hasn't been merged because I haven't had time to review it.

jeroenj commented 11 years ago

Sure, no problem.

I'm planning to push some more fixes changes like correctly the current value of a dictionary and so on. I'll keep you posted. :)

jtimberman commented 11 years ago

To make it something "global", I went with an attribute in 5896c71.

Cheers!

jeroenj commented 11 years ago

Neat. Thanks! :+1: