Sous-Chefs-Boneyard / sysctl

Development repository for the sysctl cookbook
https://supermarket.chef.io/cookbooks/sysctl
Apache License 2.0
42 stars 79 forks source link

library should reference conf_dir not conf_file #94

Closed spion06 closed 7 years ago

spion06 commented 7 years ago

Description

With 0.10.0 conf_file was deprecated however there are still incorrect references in code to that attribute. The references that are to conf_file should be to conf_dir. If conf_file is specified then no sysctl entries can be added to a node

    * template[/etc/sysctl.d/99-chef-attributes.conf/99-chef-kernel.core_uses_pid.conf] action create
      * Parent directory /etc/sysctl.d/99-chef-attributes.conf does not exist.
      ================================================================================
      Error executing action `create` on resource 'template[/etc/sysctl.d/99-chef-attributes.conf/99-chef-kernel.core_uses_pid.conf]'
      ================================================================================

      Chef::Exceptions::EnclosingDirectoryDoesNotExist
      ------------------------------------------------
Parent directory /etc/sysctl.d/99-chef-attributes.conf does not exist.

Issues Resolved

Unsure

Check List

spion06 commented 7 years ago

I'm currently working on writing some tests. the coverage on this cookbook is fairly atrocious so quite a few things aren't stubbed out yet

spion06 commented 7 years ago

after looking though a bit deeper when writing actual tests it appears the confd_sysctl method might have been the only reference that was incorrect

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.