Sous-Chefs-Boneyard / sysctl

Development repository for the sysctl cookbook
https://supermarket.chef.io/cookbooks/sysctl
Apache License 2.0
42 stars 79 forks source link

add additional test coverage #96

Closed spion06 closed 7 years ago

spion06 commented 7 years ago

Description

Adding some additional testing coverage to help prevent future issues

Issues Resolved

None I am aware of

Check List

spion06 commented 7 years ago
sysctl::default
  on Ubuntu 14.04
    should create the .d files in the specified location
  on Ubuntu 16.04
    should create the .d files in the specified location
  on Debian 7.11
    should create the .d files in the specified location
  on Debian 8.8
    should create the .d files in the specified location
  on Fedora 25
    should create the .d files in the specified location
  on Redhat 6.9
    should create the .d files in the specified location
  on Redhat 7.3
    should create the .d files in the specified location
  on Centos 6.9
    should create the .d files in the specified location
  on Centos 7.3.1611
    should create the .d files in the specified location
  on Freebsd 10.3
    should create the .d files in the specified location
  on Freebsd 11.0
    should create the .d files in the specified location
  on Suse 12.2
    should create the .d files in the specified location

sysctl::default
  on Ubuntu 14.04
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Ubuntu 16.04
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Debian 7.11
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Debian 8.8
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Fedora 25
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Redhat 6.9
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Redhat 7.3
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Centos 6.9
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Centos 7.3.1611
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Freebsd 10.3
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Freebsd 11.0
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true
  on Suse 12.2
    should not restart procps if restart_procps is false
    should start procps if restart_procps is true

sysctl_test::attributes
  testing apply action
    apply sysctl_param[vm.swappiness]

sysctl_test::resources
  testing apply action
    apply sysctl_param[vm.swappiness]

Finished in 3.82 seconds (files took 6 seconds to load)
38 examples, 0 failures

I can restructure if needed. Short of doing a full blown test of everything in the LWRP this should provide some quick wins on coverage

spion06 commented 7 years ago

@tas50 or whoever. Any issues with this PR?

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.