search

South-Paw / action-netlify-cli

🙌 Netlify deployments and CLI via GitHub actions
MIT License
10 stars 2 forks source link

Add ability to pass the Netlify CLI version #5

Open what1s1ove opened 3 weeks ago

what1s1ove commented 3 weeks ago

Hey! Thanks for creating such an awesome action!

I wanted to bring up an issue regarding the Netlify CLI. After the release of v17.36.2, it started having some problems (see details). The only current workaround is to downgrade the CLI to v17.36.1. Unfortunately, this means that anyone using this action for deployments is blocked until the Netlify team fixes the issue in future versions 🥲

South-Paw commented 1 week ago

I've also hit the same issue within a monorepo with the Netlify CLI.

I just checked out the workflows for that project as I recalled doing something to work around the issue... and it looks like I've pinned v15 explicitly in a npx command

- name: Deploy to Netlify
  run: npx --yes netlify-cli@15.11.0 deploy --json --prod --dir=apps/user/dist
  env:
    NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
    NETLIFY_SITE_ID: ${{ secrets.NETLIFY_SITE_ID }}

The downside being the command output is not being parsed nor made available by the step for other steps...

Adding a way to specify the cli package version would certainly be useful though 👍

what1s1ove commented 1 week ago

output is not being parsed nor made available by the step for other steps...

Agreed! This is a reason why I decided to use this action 🙂