Closed andrewda closed 6 years ago
Plz wait to merge, I wanna clean up the commits first
Yea ofc ofc, I just opened PR so I could fix conflict from my phone.
We'll rebase this in instead of squashing/merging but GitHub does that super uglily so let's just do it all from Git anyways.
Oh lol, yeah, I was planning on doing it directly in Git so I was super confused for a sec.
On Fri, Feb 16, 2018, 2:48 PM Andrew Dassonville notifications@github.com wrote:
Closed #32 https://github.com/SouthEugeneRoboticsTeam/PowerUp-2018/pull/32.
— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/SouthEugeneRoboticsTeam/PowerUp-2018/pull/32#event-1478826620, or mute the thread https://github.com/notifications/unsubscribe-auth/AJDRJE97Td_Tjt5D_6tOD_hw3uzi9Sknks5tVgWugaJpZM4SJBmf .
Hi @andrewda, thanks for opening this pull request!
Looks like this is an addition or fix for the robot. To make sure this change goes added in smoothly, make sure the following chores are complete (please check-off items as they are completed):
[ ] Test code changes on the robot (if possible).
[ ] Verify that significant changes have tests and pass successfully.
[ ] Ensure this pull request is appropriately titled.
Maintainers – please review this PR. A review from the @SouthEugeneRoboticsTeam/reviewers team is required before the PR can be merged.
Finally, use
@sertbot merge
to merge this PR into the appropriate branch.Thanks!