SouthForkResearch / CHaMP_Metrics

GNU General Public License v3.0
6 stars 0 forks source link

TopoAux: Tier 1 ocular substrate metrics not corrected by channel unit area #114

Open volkcj opened 6 years ago

volkcj commented 6 years ago

the tier 1 ocular substrate metrics are only reporting the raw % values. These need to be divided by the channel unit areas, similar to how the visit level metrics are calculated.

I can provide additional calc info if needed, but this is at least a reminder to update this. Example visit ID 5111

MattReimer commented 6 years ago

This is a weird one.

You're seeing

            <SlowPool>
                <Substrate>
                    <Bldr>30.0</Bldr>
                    <Cbl>25.0</Cbl>
                    <Grvl>25.0</Grvl>
                    <SandFines>20.0</SandFines>
                    <Total>100.0</Total>
                </Substrate>

but the equation IS dividing by area

Four SlowPool Substrate Bldr:

t1SumProd = {float64} 8956.467 (this is the sum o fthe values)
t1AreaTot = {float64} 298.5489 (here is the area)

The division IS happening here:
8956.467 / 298.5489 = 30.0

It does seem weird to me that these numbers should work out so perfectly but I can't figure out why this coincidence is happening.

volkcj commented 6 years ago

There are two SlowPools at this site. Can you see that values for units 4 and 7 are getting summed? These are the values for Unit 7.

I'll also check another Visit.

volkcj commented 6 years ago

this might be conflated with #112 . let's wait until next week on this.