Southampton-RSG-Training / dirac-intro-to-mpi

WIP: training material for DiRAC MPI course
https://southampton-rsg-training.github.io/dirac-intro-to-mpi/
Other
0 stars 0 forks source link

Review: 2. Introduction to the Message Passing Interface #9

Closed Edward-RSE closed 1 month ago

Edward-RSE commented 1 year ago

This issue is to track comments and changes for this episode.

Edward-RSE commented 1 year ago

Before I do a more detailed review, following from https://github.com/Southampton-RSG-Training/dirac-intro-to-mpi/issues/8#issuecomment-1607508510 in the episode 1 review, I think there is potential we would consolidate episode 2 and 3 together if we did consolidate episode 1 and 3.

Edward-RSE commented 1 year ago

What is MPI

Getting Started with MPI

Running a code with MPI

Other comments

TODO

Edward-RSE commented 1 year ago

There is also stuff we can borrow and add from our previous DiRAC material for the Slurm section: https://southampton-rsg-training.github.io/dirac-code-scaling/dirac-code-scaling-running-example-code-cluster

Edward-RSE commented 11 months ago

RE: pull request #21

I only one comment. I think it's worth saying that the prime problem is easy to split across ranks, because it's an example of an embarrassingly parallel problem (and maybe why it is EP?). And following that, mentioning that not every problem can be broken up like this with reference to, e.g., general problems vs EP problems (reference first episode) and other patterns (e.g. communication patterns episode).

What do you think?

mehtaparabaci commented 5 months ago

Running a code with MPI

I think the there is no need to include (int argc, *argv[]) command-line arguments in the hello_world.ccode.

Compile and Run

The Output should be changed to

My rank number is 1 out of 4
My rank number is 2 out of 4
My rank number is 3 out of 4
My rank number is 0 out of 4

Also we need to give it in an Output box not in a Code.

mehtaparabaci commented 5 months ago

Submitting our Program to a Batch Scheduler

typo: count-primes.sh → count_primes.sh

steve-crouch commented 1 month ago

Completed.