search

Southclaws / storyden

With a fresh new take on traditional bulletin board forum software, Storyden is a modern, secure and extensible platform for building communities.
https://www.storyden.org/
Mozilla Public License 2.0
93 stars 11 forks source link

rework library page creation and edit flows #205

Closed Southclaws closed 1 month ago

Southclaws commented 1 month ago

Creating a library page now instantly calls the POST operation and lands the user on the new page. The new page will have a placeholder name (since the API is not yet compatible with nameless nodes - to change n future)

Also consolidated all library mutations to a single hook with proper optimistic mutation and revalidation support.

Rich cards now correctly use next/link for client side navigation.

All SWR is keepPreviousData for better UX site-wide.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storyden ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 10:56am
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **storyden-homepage** | ⬜️ Ignored ([Inspect](https://vercel.com/southclaws-projects/storyden-homepage/2Cp4pDghBHr4wN1Wpjyxz3K2VDKn)) | | | Oct 11, 2024 10:56am |
coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough ## Walkthrough This pull request introduces several modifications across various components and files. Key changes include the addition of validation in the `Create` method of the `Writer` struct, updates to the `Page` component for simplified slug handling, and enhancements to the `Breadcrumbs` and `LibraryPageMenu` components. Additionally, several components such as `LibraryPageCreateTrigger` and `LibraryPageContainerScreen` have been removed, while new functionalities for creating pages have been introduced. Overall, the changes streamline the library's navigation and management features. ## Changes | File Path | Change Summary | |---------------------------------------------------------------|---------------------------------------------------------------------------------------------------------| | `app/resources/library/node_writer/node_writer.go` | Added validation check in `Create` method for non-empty `slug`. | | `web/src/app/(dashboard)/l/[...slug]/page.tsx` | Removed `getServerSession`, simplified slug handling, updated rendering to use `LibraryPageScreen`. | | `web/src/app/providers.tsx` | Wrapped `Toaster` in `SWRConfig` with `keepPreviousData` set to `true`. | | `web/src/components/library/Breadcrumbs.tsx` | Updated to use `uniq` for `libraryPath`, replaced `LibraryPageCreateTrigger` with `CreatePageAction`. | | `web/src/components/library/LibraryPageCreateTrigger/LibraryPageCreateTrigger.tsx` | Component removed. | | `web/src/components/library/LibraryPageMenu/LibraryPageMenu.tsx` | Destructured additional props and simplified `onClose` handling. | | `web/src/components/library/LibraryPageTree/LibraryPageTree.tsx` | Replaced `Box` with `HStack`, added `CreatePageAction` in menu control. | | `web/src/components/library/LibraryPageTree/useLibraryPageTree.ts` | Restructured `handleDelete` function and updated imports. | | `web/src/components/library/utils.ts` | Modified `getTargetSlug` to return a string only, removing boolean logic. | | `web/src/components/site/Navigation/Actions/CreatePage.tsx` | Introduced `CreatePageAction` for page creation functionality. | | `web/src/components/site/Navigation/ContentNavigationList/ContentNavigationList.tsx` | Added `Divider` component and layout spacing. | | `web/src/components/site/Navigation/DatagraphNavTree/DatagraphNavTree.tsx` | Replaced `AddAction` with `CreatePageAction`. | | `web/src/components/ui/rich-card.tsx` | Replaced anchor with `Link` component for client-side navigation. | | `web/src/lib/library/library.ts` | Added asynchronous methods for node management in `useLibraryMutation`. | | `web/src/screens/library/LibraryPageContainerScreen/LibraryPageContainerScreen.tsx` | Component removed. | | `web/src/screens/library/LibraryPageCreateScreen/LibraryPageCreateScreen.tsx` | Component removed. | | `web/src/screens/library/library-path.ts` | Removed `QuerySchema`, updated `joinLibraryPath` to use `uniq`. | | `web/src/utils/permissions.ts` | Introduced `hasPermissionOr` function for permission checks. | ## Possibly related PRs - **#195**: The changes in this PR involve significant renaming and routing adjustments, including the transition from "directory" to "library," which directly relates to the modifications made in the main PR regarding the `Page` component and the `getTargetSlug` function. > 🐇 In the library, we hop and play, > With slugs and paths, we find our way. > A new page action, oh what a thrill, > Removing the clutter, we streamline still. > So let’s celebrate with joy and cheer, > For every change brings us near! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.