add a primary asset cover image to library pages

Southclaws commented 1 month ago

This adds a separate asset relation to library pages: primary image, or "cover image" which acts as a hero section header for library pages.

This also introduces the concept of assets having version history. The need for this was because when a cover image is cropped, the original is still needed in order to facilitate future edits to the crop.

from discord:

this, it's a fixed height but obviously dynamic width, so you can drop an image in and move it around a bit so it's positioned nicely

hard part: because the width is dynamic, the cropped coordinates are invalid for that use-case

img has object-fit/object-position, but the coordinate space is different because it's dependent screen space coordinates not image space coordinates

so I think the only solution is to store two images, one is the original and the other is the cropped version (which can be deleted/replaced when the original is edited)

when you enter edit mode, it loads the original image and when it's rendered for reading, it loads the cropped image

So now I'm wondering if it makes sense to add a recursive backreference to Assets for change versioning :thinkthonk:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
storyden	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 8:30pm

1 Skipped Deployment

coderabbitai[bot] commented 1 month ago

📝 Walkthrough

## Walkthrough The changes in this pull request introduce a new field, `PrimaryImage`, to the `Node` struct across various files, enhancing the data structure to include a reference to a primary image. This involves updates to methods for creating, updating, and querying nodes, including the addition of new methods and modifications to existing ones. The entity-relationship diagram and migration schema have also been updated to reflect these changes. Additionally, new components and hooks for managing asset uploads and cover images have been added, improving the user interface for library pages and media assets. ## Changes | File Path | Change Summary | |------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | app/resources/library/mapping.go, app/resources/library/node.go, app/services/library/node_mutate/node.go, app/transports/http/bindings/nodes.go, internal/ent/node.go, internal/ent/node_create.go, internal/ent/node_update.go, internal/ent/schema/node.go | Added `PrimaryImage` field to `Node` struct and updated related methods to handle this new field. Introduced `QueryPrimaryImage` method and updated the entity-relationship diagram to include `primary_asset_id`. | | app/resources/library/node_querier/node_querier.go, app/resources/library/node_search/search.go | Modified `Get` and `Search` methods to include `WithPrimaryImage()` for enhanced query capabilities. | | app/resources/library/node_writer/node_writer.go | Introduced `WithPrimaryImage` function for setting the primary asset ID in `ent.NodeMutation`. | | internal/ent/er.html, internal/ent/migrate/schema.go | Updated ERD and migration schema to include `primary_asset_id` field with foreign key constraints. | | web/src/api/openapi-schema/nodeCommonProps.ts, web/src/api/openapi-schema/nodeInitialProps.ts, web/src/api/openapi-schema/nodeMutableProps.ts | Added `primary_image` and `primary_image_asset_id` properties to `NodeCommonProps`, `NodeInitialProps`, and `NodeMutableProps` interfaces. | | web/src/components/asset/AssetUploadAction.tsx, web/src/components/library/LibraryPageCoverImageControl/LibraryPageCoverImageControl.tsx, web/src/components/library/LibraryPageCoverImageControl/useLibraryPageCoverImageControl.ts | Introduced components and hooks for managing asset uploads and cover images. | | web/src/screens/library/LibraryPageScreen/LibraryPageScreen.tsx, web/src/screens/library/LibraryPageScreen/useLibraryPageScreen.ts | Integrated new cover image handling functionality into `LibraryPageScreen` and updated associated hook for image cropping. | | web/src/screens/media/MediaEditModal.tsx, web/src/screens/media/MediaEditScreen.tsx | Added components for editing media assets and managing media uploads. | | web/styled-system/recipes/file-upload.d.ts, web/styled-system/recipes/file-upload.mjs | Modified `FileUploadRecipe` interface and updated `fileUploadSlotNames` array to include additional keys. | ## Possibly related PRs - **#189**: The main PR introduces a new field `PrimaryImage` to the `Node` struct and updates various methods to handle this field, while this PR focuses on adding and modifying operations related to reactions, which may involve similar data handling patterns. - **#198**: This PR reworks the thread screen design and re-adds reactions, which could relate to the changes in the main PR that enhance the data structure for nodes, potentially impacting how reactions are displayed or managed in the context of nodes. > 🐇 In the library where images gleam, > A `PrimaryImage` now reigns supreme. > With queries enhanced, and uploads in play, > Our nodes shine brighter, come what may! > Hops of joy for the changes we see, > A vibrant new world, oh, how it will be! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

Southclaws / storyden

add a primary asset cover image to library pages #224