Add role management - Githubissues

Southclaws commented 2 weeks ago

still to do:

disable editing of default roles (member/admin) until overlays/replacements/defaults implemented in API
/roles page needs some way of finding it
role badge should link to roles page?
minor underflow issue on modal, need some padding on scrollable area:

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
storyden	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 4, 2024 11:52am

1 Skipped Deployment

coderabbitai[bot] commented 2 weeks ago

📝 Walkthrough

## Walkthrough The changes in this pull request focus on modifying the foreign key constraints within the `AccountRolesTable` and the `AccountRoles` schema. Specifically, the `OnDelete` behavior for two foreign keys has been updated from `schema.NoAction` to `schema.Cascade`, allowing for cascading deletions. Additionally, the `AccountRoles` schema has been updated to include annotations that enforce this cascading behavior for relationships with the `Account` and `Role` entities. An import statement for `entsql` has also been added to support these changes. ## Changes | File | Change Summary | |-------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------| | internal/ent/migrate/schema.go | Updated foreign key constraints in `AccountRolesTable`: changed `OnDelete` from `schema.NoAction` to `schema.Cascade` for two foreign keys. | | internal/ent/schema/account_role.go | Added `import "entgo.io/ent/dialect/entsql"`; updated edges for "account" and "role" relationships to include `Annotations(entsql.OnDelete(entsql.Cascade))`. | | web/src/app/(dashboard)/roles/page.tsx | Added new asynchronous React component `Page` for fetching user session data and roles, rendering `RoleScreen` or `UnreadyBanner` based on fetch results. | | web/src/components/library/members/MemberList.tsx | Updated import path for `RoleBadgeList` component due to project restructuring. | | web/src/components/member/MemberBadge/MemberIdent.tsx | Changed import path for `RoleBadgeList` and updated `Roles` component to use it, encapsulating role display logic. | | web/src/components/member/MemberRoleMenu/MemberRoleMenu.tsx | Updated import path for `RoleBadge` component due to project restructuring. | | web/src/components/member/RoleBadge/RoleBadge.tsx | Removed `RoleBadge` component that displayed user role badges with color manipulation. | | web/src/components/role/RoleBadge/RoleBadge.tsx | Introduced new `RoleBadge` component for displaying user role badges with color manipulation. | | web/src/components/role/RoleCard.tsx | Added new `RoleCard` component for displaying role information and associated permissions. | | web/src/components/role/RoleEdit/RoleEditModal.tsx | Introduced components for editing and creating roles within a modal interface. | | web/src/components/role/RoleEdit/RoleEditScreen.tsx | Added `RoleEditScreen` component for editing roles with a form interface. | | web/src/components/role/RoleEdit/useRoleEdit.ts | Introduced custom hook `useRoleEditScreen` for managing role editing functionality. | | web/src/components/role/RoleOptionsMenu/RoleOptionsMenu.tsx | Added `RoleOptionsMenu` component for role-related actions with editing and deletion options. | | web/src/components/role/colours.ts | Introduced functions for handling color manipulation for badges. | | web/src/components/site/Action/Edit.tsx | Replaced `PencilIcon` with `EditIcon` in `EditAction` component. | | web/src/components/site/DeleteConfirmationButton.tsx | Added `DeleteWithConfirmationButton` component for confirming delete actions. | | web/src/components/site/Modaldrawer/Modaldrawer.tsx | Added `overflowY="scroll"` to the `Box` component in `ModalDrawer` for vertical scrolling. | | web/src/components/ui/checkbox.tsx | Restructured `Checkbox` component with new components and removed `CheckboxProps` interface. | | web/src/components/ui/form/CardGroupSelect.tsx | Introduced `CardGroupSelect` component for rendering selectable cards with checkboxes. | | web/src/lib/permission/permission.ts | Introduced schema and structure for managing permissions using `zod` library. | | web/src/screens/role/RoleScreen.tsx | Added `RoleScreen` component for displaying a list of roles with associated permissions and customization options. | ## Poem > In fields of code where rabbits play, > Cascading changes come our way. > With foreign keys that dance and twirl, > Deletions flow, a graceful whirl. > Hopping through schemas, we celebrate, > A world of data, oh, how great! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

Southclaws / storyden

Add role management #277