Southclaws / storyden

With a fresh new take on traditional bulletin board forum software, Storyden is a modern, secure and extensible platform for building communities.
https://www.storyden.org/
Mozilla Public License 2.0
93 stars 11 forks source link

Organise icons and misc tidy up #279

Closed Southclaws closed 2 weeks ago

Southclaws commented 2 weeks ago

consolidate most action icons into re-exports and migrate mostly to Lucide icons

also fix some minor issues with the mobile menu, removed some rarely/never used components

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storyden ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 3:48pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **storyden-homepage** | ⬜️ Ignored ([Inspect](https://vercel.com/southclaws-projects/storyden-homepage/ECZVxTDNDoFhVoixtiv5gFo7N8iW)) | [Visit Preview](https://storyden-homepage-git-organise-iconography-southclaws-projects.vercel.app) | | Nov 6, 2024 3:48pm |
coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough ## Walkthrough This pull request introduces significant changes across multiple components, primarily focusing on the restructuring of icon imports and the introduction of new styled icon components. Key modifications include the removal of several existing icon components and their replacement with new styled counterparts sourced from the `lucide-react` library. Additionally, updates were made to various components to utilize these new icons, ensuring consistent styling and functionality throughout the application. ## Changes | File Path | Change Summary | |-----------|----------------| | web/src/components/form/ColourInput/ColourInput.tsx | Updated import path for `DragHandleIcon` and modified its usage to include a `color` prop. | | web/src/components/graphics/CheckCircle.tsx | File removed; contained a `CheckCircle` component. | | web/src/components/graphics/CrownIcon.tsx | File removed; contained a `CrownIcon` component. | | web/src/components/graphics/DragHandleIcon.tsx | File removed; contained a `DragHandleIcon` component. | | web/src/components/graphics/LoginIcon.tsx | File removed; contained a `LoginIcon` component. | | web/src/components/graphics/LogoutIcon.tsx | File removed; contained a `LogoutIcon` component. | | web/src/components/graphics/Mailbox.tsx | File removed; contained a `Mailbox` component. | | web/src/components/graphics/SendIcon.tsx | File removed; contained a `SendIcon` component. | | web/src/components/graphics/SpeechPlusIcon.tsx | File removed; contained a `SpeechPlusIcon` component. | | web/src/components/library/Breadcrumbs.tsx | Updated import path for `CreatePageAction`. | | web/src/components/library/CreatePage.tsx | Changed icon from `PlusIcon` to `CreateIcon`. | | web/src/components/library/Header.tsx | File removed; contained a `DatagraphHeader` component. | | web/src/components/library/LibraryPageTree/LibraryPageTree.tsx | Updated import path for `CreatePageAction`. | | web/src/components/notifications/NotificationsMenu.tsx | Replaced `NotificationAction` with `NotificationsTrigger`. | | web/src/components/notifications/NotificationsTrigger.tsx | Renamed `NotificationAction` to `NotificationsTrigger`, updated icon import. | | web/src/components/role/PermissionList.tsx | Enhanced rendering logic for permissions. | | web/src/components/role/RoleEdit/RoleEditModal.tsx | Replaced `AddAction` with `IconButton` and added `CreateIcon`. | | web/src/components/site/Action/Add.tsx | File removed; contained an `AddAction` component. | | web/src/components/site/Action/Back.tsx | File removed; contained a `BackAction` component. | | web/src/components/site/Action/Bookmark.tsx | Updated icon imports for bookmarks. | | web/src/components/site/Action/Cancel.tsx | Replaced `XIcon` with `CancelIcon`. | | web/src/components/site/Action/Close.tsx | Replaced `XMarkIcon` with `CloseIcon`. | | web/src/components/site/Action/Edit.tsx | Updated import for `EditIcon`. | | web/src/components/site/Action/More.tsx | Replaced `EllipsisHorizontalIcon` with `MoreIcon`. | | web/src/components/site/Action/Save.tsx | Replaced `CloudArrowUpIcon` with `SaveIcon`. | | web/src/components/site/Action/Send.tsx | File removed; contained a `SendAction` component. | | web/src/components/site/Avatar/Avatar.tsx | File removed; contained an `Avatar` component. | | web/src/components/site/Avatar/useAvatar.ts | File removed; contained a `useAvatar` function. | | web/src/components/site/InfoTip.tsx | Updated imports for `InfoIcon` and `IconButton`. | | web/src/components/site/Navigation/AccountMenu/AccountMenu.tsx | Added `size` prop to `AccountMenu` component. | | web/src/components/site/Navigation/Actions/Menu.tsx | File removed; contained a `MenuAction` component. | | web/src/components/site/Navigation/Anchors/Admin.tsx | Updated icon import from `CrownIcon` to `AdminIcon`. | | web/src/components/site/Navigation/Anchors/Compose.tsx | Updated icon import from `PlusIcon` to `CreateIcon`. | | web/src/components/site/Navigation/Anchors/Drafts.tsx | Updated icon import from `DocumentIcon` to `DraftIcon`. | | web/src/components/site/Navigation/Anchors/Home.tsx | Updated import for `HomeIcon`. | | web/src/components/site/Navigation/Anchors/Library.tsx | Updated icon import from `BookOpenIcon` to `LibraryIcon`. | | web/src/components/site/Navigation/Anchors/Logout.tsx | Updated import for `LogoutIcon`. | | web/src/components/site/Navigation/Anchors/Members.tsx | Updated icon import from `UsersIcon` to `MembersIcon`. | | web/src/components/site/Navigation/Anchors/Notifications.tsx | Updated icon import from `BellIcon` to `NotificationIcon`. | | web/src/components/site/Navigation/Anchors/Profile.tsx | Updated icon import from `CircleUserRoundIcon` to `ProfileIcon`. | | web/src/components/site/Navigation/Anchors/Queue.tsx | Updated icon import from `QueueListIcon` to `QueueIcon`. | | web/src/components/site/Navigation/Anchors/Settings.tsx | Updated icon import from `Cog6ToothIcon` to `SettingsIcon`. | | web/src/components/site/Navigation/LibraryNavigationTree/LibraryNavigationTree.tsx | Updated import path for `CreatePageAction`. | | web/src/components/site/Navigation/MobileCommandBar/MobileCommandBar.tsx | Replaced `ProfilePill` with `AccountMenu` and introduced `ExpandTrigger`. | | web/src/components/site/Onboarding/Checklist/ChecklistItem.tsx | Updated icon import from `CheckCircle` to `CheckCircleIcon`. | | web/src/components/site/ProfilePill/Handle.tsx | File removed; contained a `Handle` component. | | web/src/components/site/ProfilePill/ProfilePill.tsx | File removed; contained a `ProfilePill` component. | | web/src/components/site/Toolpill/Toolpill.tsx | Updated padding in `Toolpill` component. | | web/src/components/thread/ReplyBox/ReplyBox.tsx | Replaced `ProfilePill` with `MemberIdent`. | | web/src/components/ui/icons/Admin.tsx | New file; exports `AdminIcon`. | | web/src/components/ui/icons/Bookmark.tsx | New file; exports `BookmarkSavedIcon` and `BookmarkIcon`. | | web/src/components/ui/icons/Cancel.tsx | New file; exports `CancelIcon`. | | web/src/components/ui/icons/CheckCircle.tsx | New file; exports `CheckCircleIcon`. | | web/src/components/ui/icons/Close.tsx | New file; exports `CloseIcon`. | | web/src/components/ui/icons/Create.tsx | New file; exports `CreateIcon`. | | web/src/components/ui/icons/Draft.tsx | New file; exports `DraftIcon`. | | web/src/components/ui/icons/DragHandle.tsx | New file; exports `DragHandleIcon`. | | web/src/components/ui/icons/Edit.tsx | New file; exports `EditIcon`. | | web/src/components/ui/icons/Home.tsx | New file; exports `HomeIcon`. | | web/src/components/ui/icons/Info.tsx | New file; exports `InfoIcon`. | | web/src/components/ui/icons/Library.tsx | New file; exports `LibraryIcon`. | | web/src/components/ui/icons/Logout.tsx | New file; exports `LogoutIcon`. | | web/src/components/ui/icons/Members.tsx | New file; exports `MembersIcon`. | | web/src/components/ui/icons/Menu.tsx | New file; exports `MenuIcon`. | | web/src/components/ui/icons/More.tsx | New file; exports `MoreIcon`. | | web/src/components/ui/icons/Notification.tsx | New file; exports `NotificationIcon`. | | web/src/components/ui/icons/Profile.tsx | New file; exports `ProfileIcon`. | | web/src/components/ui/icons/Queue.tsx | New file; exports `QueueIcon`. | | web/src/components/ui/icons/Save.tsx | New file; exports `SaveIcon`. | | web/src/components/ui/icons/Settings.tsx | New file; exports `SettingsIcon`. | ## Possibly related PRs - **#202**: The changes in this PR involve modifications to the `NotificationsMenu` component, which is directly related to the `DragHandleIcon` component used in the `ColourInput` component. Both PRs involve updates to icon components and their usage within the UI, indicating a shared focus on improving the iconography in the application. - **#206**: The main PR's modifications to the `ColourInput` component's icon usage and import path relate to the rework of categories, which may involve similar icon management and rendering practices. - **#210**: The changes in the main PR regarding the `DragHandleIcon` are relevant to the bug fixes in the rich text editor, as both involve icon components and their rendering within the UI. - **#258**: The updates in the main PR regarding the `DragHandleIcon` are related to the changes in the `ContentComposer`, which also involves managing icons and their rendering in a content editing context. > "In the garden where icons bloom, > New paths forged, dispelling gloom. > With colors bright and styles anew, > Our UI sings, fresh as the dew. > From Check to Cancel, each in place, > A rabbit's joy in this design space!" 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.