search

Southclaws / storyden

With a fresh new take on traditional bulletin board forum software, Storyden is a modern, secure and extensible platform for building communities.
https://www.storyden.org/
Mozilla Public License 2.0
93 stars 11 forks source link

Rework OAuth2 providers #304

Closed Southclaws closed 3 days ago

Southclaws commented 3 days ago

Also updated and fixed some auth frontend issues

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **storyden** | ⬜️ Ignored ([Inspect](https://vercel.com/southclaws-projects/storyden/4iAupS5Wvrbu92VukuExXXNGYwm4)) | [Visit Preview](https://storyden-git-rework-oauth-providers-southclaws-projects.vercel.app) | | Nov 22, 2024 3:58pm | | **storyden-homepage** | ⬜️ Ignored ([Inspect](https://vercel.com/southclaws-projects/storyden-homepage/56H7dqjt4ZJFnu7ATeJhFy7NFaAn)) | [Visit Preview](https://storyden-homepage-git-rework-oauth-p-0ed196-southclaws-projects.vercel.app) | | Nov 22, 2024 3:58pm |
coderabbitai[bot] commented 3 days ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough ## Walkthrough The pull request introduces significant modifications to the authentication system by adding support for Discord as an OAuth provider. This includes the addition of a new service mode, `ServiceOAuthDiscord`, replacing the previous LinkedIn service. The changes extend to various components, including the `Registrar` struct, which now includes new methods for account creation via email and handle. Additionally, several React components are introduced or modified to integrate the new provider, enhancing the user interface for authentication options. ## Changes | File Path | Change Summary | |-----------------------------------------------------|---------------------------------------------------------------------------------------------------------| | `app/resources/account/authentication/authentication_enum_gen.go` | Added `ServiceOAuthDiscord`, updated `Format` and `NewService` methods to handle the new service type. | | `app/resources/account/authentication/service.go` | Removed `serviceOAuthLinkedin`, added `serviceOAuthDiscord`. | | `app/services/account/register/register.go` | Updated `Registrar` struct with new fields and methods for account creation via email and handle. | | `app/services/authentication/provider/oauth/discord/discord.go` | Introduced new OAuth provider for Discord with necessary methods for authentication. | | `app/services/authentication/provider/oauth/github/github.go` | Updated `Provider` struct to integrate user registration and improved error handling. | | `app/services/authentication/provider/oauth/google/google.go` | Simplified `Provider` struct and improved error handling in methods. | | `app/services/authentication/provider/oauth/linkedin/linkedin.go` | Removed LinkedIn provider implementation. | | `app/services/authentication/service.go` | Updated imports to replace LinkedIn with Discord provider. | | `web/src/api/common.ts` | Modified `buildPayload` to handle string data types directly. | | `web/src/api/server.ts` | Updated `fetcher` function to improve header management. | | `web/src/app/(bare)/auth/[provider]/callback/layout.tsx` | Introduced `Layout` component for organizing child components. | | `web/src/app/(bare)/auth/[provider]/callback/page.tsx` | Transformed `Page` component to use hooks for navigation and error handling. | | `web/src/app/(bare)/error.tsx` | Introduced `Error` component for structured error handling. | | `web/src/app/(bare)/login/layout.tsx` | Added `OAuthProviderList` component to the layout. | | `web/src/app/(bare)/register/layout.tsx` | Replaced `AuthSelection` with `OAuthProviderList`. | | `web/src/components/auth/OAuthProviderList.tsx` | Implemented component to fetch and display OAuth providers. | | `web/src/components/settings/AuthMethodSettings/AuthMethodSettings.tsx` | Modified conditional rendering logic for `OAuth` component. | | `web/src/components/settings/AuthMethodSettings/OAuth/OAuth.tsx` | Updated structure and rendering logic for `OAuth` component. | | `web/src/components/settings/AuthMethodSettings/useAuthMethodSettings.ts` | Enhanced filtering logic for active OAuth providers. | | `web/src/lib/auth/oauth.ts` | Introduced functionality for filtering authentication providers with a link property. | | `web/src/lib/auth/utils.ts` | Updated filtering logic for OAuth providers to use the new `filterWithLink` function. | | `web/src/screens/auth/components/AuthMethod/AuthMethod.tsx` | Removed `AuthMethod` component. | | `web/src/screens/auth/components/AuthSelection/AuthSelection.tsx` | Removed `AuthSelection` component. | ## Possibly related PRs - **#189**: Modifications to the `Service` type and addition of a new service mode for Discord. - **#195**: Changes to the authentication providers, specifically replacing LinkedIn with Discord. - **#196**: Enhancements to error handling relevant to authentication flow. - **#198**: User experience improvements that may relate to service interactions. - **#224**: UI enhancements that could be influenced by changes in service management. - **#277**: Introduction of role management intersecting with authentication changes. - **#281**: Breaking change regarding service configuration affecting user authentication. - **#302**: Implementation of an infinite-scroll feature potentially influenced by new service modes. > "In the world of code, a rabbit hops with glee, > New OAuth paths for all to see! > Discord joins the fun, LinkedIn takes a bow, > With each new feature, we cheer and wow! > From logins to layouts, all snug and tight, > Hopping through changes, our future looks bright! 🐇✨"

[!WARNING]

Rate limit exceeded

@Southclaws has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between a6bb12de5645bf4f90d2a1c13911e9cc68684757 and 5b28756ced0f1ae9d2ee4f4bf3198501dce36d8d.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.