Fix issues obtaining the JWT

Southern-Company-HA / southern_company_api

An api to control southern company websites

MIT License

4 stars 6 forks source link

Fix issues obtaining the JWT #14

Closed rixth closed 4 months ago

rixth commented 4 months ago

Couple things have broken/changed on SC's end.

LoginComplete now 500s on a null being sent as the ReturnUrl. Send a valid value.
LoginComplete now returns a 302 on success. Cookies are only returned by aiohttp for the last request that was followed, so we need to disable following redirects.

I confirmed that error handling for invalid username/password still works as expected.

Resolves https://github.com/Southern-Company-HA/southern-company-hacs/issues/80

cc @Lash-L @dcsim0n

Lash-L commented 4 months ago

Thanks @rixth I'll try this out sometime tomorrow!

Lash-L commented 4 months ago

From a quick test - it seems to run, thanks!

Can you change all of the instances of 200 in the tests to 302? Otherwise it wont output a release

dcsim0n commented 4 months ago

@rixth, let me know if you can't get around to finishing the PR, I can try and jump in.

rixth commented 4 months ago

@Lash-L good to go!

Lash-L commented 4 months ago

Thank you @rixth

Lash-L commented 4 months ago

@rixth If you have time, please investigate it still not working properly on the hacs integration. I have not done much with it, but I did bump the version and do some other 'chores' on the repo

Lash-L commented 4 months ago

Please ignore - I should have it fixed in the latest update