search

SovereignCloudStack / cluster-stack-operator

The SCS Cluster Stack Operator takes care of life cycle management, configuration and provider specific tasks of Kubernetes clusters created with SCS Cluster Stacks
https://scs.community/
Apache License 2.0
10 stars 3 forks source link

Create helm-releases instead of `helm template | kubectl apply -f -` #153

Open mxmxchere opened 4 months ago

mxmxchere commented 4 months ago

Helm should be used to create helm-releases. That is the way how helm is supposed to be used. The documentation of helm refers to the scenario where helm is used that way. helm template is useful for debugging but it is not supposed to be used to create the manifests that are then applied to the cluster. helm template lacks important features like capabilities, notes, upgrade and rollback, to just name a few.

In the worst case chart A version 1 deploys a configmap and in version 2 the configmap is changed to a secret. In the current approach the configmap will be stuck in the cluster forever. With helm upgrade, that configmap would be removed.

janiskemper commented 4 months ago

we have that logic you mentioned in the example implemented in the cso. @batistein can maybe say in detail why we chose to not use helm install. I know that there are some shortcomings.

What do you miss as feature in detail, from user perspective? Or do you rather suggest a different way of implementing it, without any user-facing change?