SovereignCloudStack / cluster-stack-provider-openstack

Cluster Stack Provider OpenStack
https://scs.community/
Apache License 2.0
1 stars 0 forks source link

:sparkles: Add hash mode compatibility #108

Closed matofeder closed 7 months ago

matofeder commented 7 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #99

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

matofeder commented 7 months ago

do you never work with the version itself, so that this is enough?

CSPO does not take the CS version into account right now. It takes the node image name from the node-images.yaml and uploads it to OpenStack. Hence images with the same name could be consumed by CSs in different versions.

This should be improved, and IMO CSO should take the node-image version (metadata) into account, somehow. But this is not trivial and will be discussed in a separate issue.

janiskemper commented 7 months ago

okay! Then I guess someone should test the whole workflow starting from generating a hash release with csctl and then see whether it works with cso and cspo! Code-wise it looks alright to me, but the change is also very small. Therefore testing will be more important I guess!

michal-gubricky commented 7 months ago

okay! Then I guess someone should test the whole workflow starting from generating a hash release with csctl and then see whether it works with cso and cspo! Code-wise it looks alright to me, but the change is also very small. Therefore testing will be more important I guess!

Today, I tested the entire workflow, beginning with the use of csctl to generate a hash release with the local_mode set to cspo and cso. It seems to be working; I found no error logs in either controller, and all cluster-stack resources were ready.

janiskemper commented 7 months ago

sounds great!