SovereignCloudStack / cluster-stacks

Definition of Cluster Stacks based on the ClusterAPI ClusterClass feature
https://scs.community/
Apache License 2.0
7 stars 6 forks source link

fix(cluster-class): options from different api versions somehow mixed up #131

Closed jschoone closed 4 days ago

jschoone commented 1 week ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #129

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

cluster_stack = "providers/openstack/scs"
scszuulapp[bot] commented 1 week ago

Build failed (e2e-quick-test pipeline). https://zuul.scs.community/t/SCS/buildset/93f5c618417d4db79918c6e74469d9d3

:x: e2e-openstack-quick FAILURE in 4m 16s

scszuulapp[bot] commented 1 week ago

Build failed (e2e-quick-test pipeline). https://zuul.scs.community/t/SCS/buildset/468aceff46cc4c21a75a820ca9fdc681

:x: e2e-openstack-quick FAILURE in 41m 56s

jschoone commented 6 days ago

Hi @chess-knight and @DEiselt could you have a look if theres something left and/or I made something wrong? My first tests worked so far

scszuulapp[bot] commented 5 days ago

Build failed (e2e-quick-test pipeline). https://zuul.scs.community/t/SCS/buildset/96488be537f04f3da611c6caebe431a6

:x: e2e-openstack-quick FAILURE in 10m 44s

scszuulapp[bot] commented 5 days ago

Build failed (e2e-quick-test pipeline). https://zuul.scs.community/t/SCS/buildset/e1ab5fb1ad3840f29feba4097a6c968b

:x: e2e-openstack-quick FAILURE in 10m 53s

michal-gubricky commented 5 days ago

Build failed (e2e-quick-test pipeline). https://zuul.scs.community/t/SCS/buildset/e1ab5fb1ad3840f29feba4097a6c968b

e2e-openstack-quick FAILURE in 10m 53s

Ah, based on the last run, it seems the infrastructure running the Zuul tests is slow, as it takes over 3 minutes for pods in the kube-system to be ready in the kind cluster that is usually not a problem. I will try to run this pipeline later today.

michal-gubricky commented 5 days ago

Build failed (e2e-quick-test pipeline). https://zuul.scs.community/t/SCS/buildset/468aceff46cc4c21a75a820ca9fdc681

e2e-openstack-quick FAILURE in 41m 56s

Based on this failed pipeline and further investigation, we need to adjust the e2e tests, as the structure of this repository has changed. I will create an issue and start working on that.

DEiselt commented 4 days ago

@jschoone it looks like @michal-gubricky and i found the issue with the e2e tests. I will merge this PR now.