search

SovereignCloudStack / cluster-stacks

Definition of Cluster Stacks based on the ClusterAPI ClusterClass feature
https://scs.community/
Apache License 2.0
7 stars 6 forks source link

Feat/alpha 129 #43

Closed jschoone closed 4 months ago

jschoone commented 5 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

jschoone commented 5 months ago

Hi @chess-knight, could you test this release on gx-scs (or an Openstack cloud of your choice :smile:) using CSO and CSPO? This is alread available as pre-release. For the secret for the workload cluster I still use the Helm chart from Malte this way: helm template https://github.com/SovereignCloudStack/cluster-stacks/releases/download/openstack-alpha-1-28-v3/csp-helper-chart.tgz -f path/to/clouds.yaml | kubectl apply -f - If that works, I suggest to have this in the Quickstart docs in the CSPO including ClusterStack, OpenStackClusterStackReleaseTemplate and Cluster examples, because it's currently a bit confusing when reading this on the docs page instead of the CSPO repo itself.

Hi @janiskemper, could you have a look if the Cluster Stack structure is as it should be? I still use the << >> notation here, when I understand the issue you sent me (https://github.com/SovereignCloudStack/csctl/issues/102) correct, this can be avoided in the future?

For both of you, of course, you are welcome to pass the review request on to a teammate. :)

chess-knight commented 5 months ago

Hi @jschoone, I tested the pre-release and it works for me.

I also find that pre-release differs from this PR - securityGroups missing in the OpenStack templates. So I guess you also noticed it, so you removed it from pre-release. Please, check #45

mxmxchere commented 5 months ago

I can also confirm that this release works (i mean what is in the release, not this PR :)

@chess-knight yes, the helper chart is not where it should be yet. The idea with the project-namespace relation is that all the resources (namespace, secrets, CSO, CSPO resources) are needed per namespace and tenant (which brings me to a 1:1 relation of tenant and namespace). If you have a non-application-credential you can extract the tenant/namespace nicely from project_name. I created a separate issue for that (https://github.com/SovereignCloudStack/cluster-stacks/issues/46) if you have an idea how to deal with it, your proposal is more than welcome :)