Implement ability of OpenStack services to use redis as their oslo caching backend

[fdobrovolny]

Epic #462

Blocks #464

As an SCS Operator, I want to use Ansible Kolla to deploy OpenStack Services with Redis backend for the future possibility of E2E encryption of OpenStack services.

Definition of Ready:

• [ ] User Story is clear and understood by the whole team
• [ ] Acceptance criteria are defined
• [ ] Acceptance criteria are clear and understood by the whole team

Definition of Done:

• [x] Ansible Kolla can deploy OpenStack services with Redis as a caching backend.
• [ ] The patch has been submitted to upstream and merged.
• [ ] Change has been included in the testbed.
• [ ] CI tests have run successfully
• [ ] Documentation has been updated
• [ ] Release Notes have been updated

[MatusJenca2]

Issue Progress

Openstack services using oslo.cache

• Services that utilize oslo.cache library already support Redis (without TLS) as backend
• Add this option to kolla ansible, here's a kolla fork that has it
• After review of PR in forked repo by @fdobrovolny it a PR can be created in upstream

Horizon

• Horizon uses Django and it's caching abilities

• Version of Django that Horizon uses does not support support redis cache, unless an additional library django_redis is installed

• This would require changes in the Docker images Kolla uses, I suggest we make it a sepparate issue

• Can be temporarily "hacked" by using docker exec

  
  # Add to ansible/roles/horizon/tasks/bootstrap.yml

• name: Install additional library to Horizon for Redis Cache community.docker.docker_container_exec: container: horizon command: bash -c "source /var/lib/kolla/venv/bin/activate; pip install django_redis" become: yes

  
  ## Keystone_auth

• Keystone middleware cannot use Redis as caching backend, options are :

  • Memcached - we probably don't want to use that because of no TLS
  • Openstack Swift - is an Openstack Service, most probably has TLS as other OS services.

• I suggest we make this a sepparate issue, because it's using Swift, not Redis

• Openstack seems to be working with Memacached disabled (Redis is used also for Horizon). This is however a single project on the single node, not sure if it works properly on real OS deployments. Also, we probably want users to be able to use caching feature for keystone_auth

[berendt]

From m POV it makes no sense to use Swift as caching backend for Keystone because we have to integrate Ceph RGW with Keystone to be able to use the Swift API with Ceph RGW.

[fdobrovolny]

Upstream PR was made: Upstream bug: https://blueprints.launchpad.net/kolla-ansible/+spec/redis-caching-backend Upstream PR: https://review.opendev.org/c/openstack/kolla-ansible/+/903978

[fkr]

@artificial-intelligence we could use your assistance here - since there are couple comments in the gerrit review that @MatusJenca2 is unsure on how to address them. Maybe schedule a joint interactive session?

[MatusJenca2]

Issue Progress

This issue needs changes in oslo.chache to be able to us Redis in HA mode (Redis Sentinel) with or without TLS. Our assumption was that these changes are not needed if we don't want TLS, but as it turns out, it's needed even w/o TLS if we want Sentinel, because there is no support for Sentinel backend implemented

• [x] implement support for Redis Sentinel backend in oslo.cache
• [ ] update this issue to include TLS
• [x] implement TLS support for Redis Sentinel backend
• [x] test functionality in all-in-one mode
• [x] create an internal PR into a forked oslo.cache repo ( for review before upstream PR) - PR created oslo.cache/!1
• [x] review the PR (@fdobrovolny )
• [ ] test in HA mode (need HA environment @fdobrovolny: should we create a sepparate issue for that, because we will need it)
• [ ] create a PR in oslo.cache upstream
• [ ] create/update existing PR in kolla upstream. Update the linked blueprint to already include TLS Mention that it's dependent on oslo.cache upstream PR, or create it after oslo.cache PR is merged

[artificial-intelligence]

I'll just quote my mail to SCS-Tech list here, for the sake of completeness:

Hi everyone,

seems we need to hurry if we want to get the needed patches into oslo.cache, as the feature freeze is nearing fast (see the attached mail).

Currently there are two different approaches to provide redis sentinel in oslo.cache:

https://review.opendev.org/c/openstack/oslo.cache/+/907211 (by Matus @dnation) https://review.opendev.org/c/openstack/oslo.cache/+/907336 (from a core oslo maintainer)

if you can provide feedback on the patches, please do so asap.

Thanks

Sven

-------- Weitergeleitete Nachricht -------- Von: Daniel Bengtsson [dbengt@redhat.com](mailto:dbengt@redhat.com) An: openstack-discuss@lists.openstack.org Betreff: [oslo] Feature freeze. Datum: 01.02.2024 15:40:32

Hi there,

Just a friendly reminder that oslo's feature freeze will happen in 2 weeks (R-7 - Feb 12 - Feb 16). To know more about the freeze, we have a policy[1] that discusses it.

The main thing is that if you have features you want to get into Oslo libraries this cycle, please make sure they merge by Friday. After that we will need to go through the FFE process and there is no guarantee we can land them. Feel free to ping us on IRC if you need code review.

[1] http://specs.openstack.org/openstack/oslo-specs/specs/policy/feature-freeze.html

-- Daniel Bengtsson Software Engineer

[MatusJenca2]

I have troubles making kolla-ansible work with the second pull request, https://review.opendev.org/c/openstack/oslo.cache/+/907336 (from a core oslo maintainer), I'd perhaps consider merging mine. This still might be a problem on my end.

On Thu, Feb 1, 2024 at 4:28 PM Sven @.***> wrote:

I'll just quote my mail to SCS-Tech list here, for the sake of completeness:

Hi everyone,

seems we need to hurry if we want to get the needed patches into oslo.cache, as the feature freeze is nearing fast (see the attached mail).

Currently there are two different approaches to provide redis sentinel in oslo.cache:

https://review.opendev.org/c/openstack/oslo.cache/+/907211 (by Matus @dnation https://github.com/dnation) https://review.opendev.org/c/openstack/oslo.cache/+/907336 (from a core oslo maintainer)

if you can provide feedback on the patches, please do so asap.

Thanks

Sven

-------- Weitergeleitete Nachricht -------- Von: Daniel Bengtsson @.> An: @. Betreff: [oslo] Feature freeze. Datum: 01.02.2024 15:40:32

Hi there,

Just a friendly reminder that oslo's feature freeze will happen in 2 weeks (R-7 - Feb 12 - Feb 16). To know more about the freeze, we have a policy[1] that discusses it.

The main thing is that if you have features you want to get into Oslo libraries this cycle, please make sure they merge by Friday. After that we will need to go through the FFE process and there is no guarantee we can land them. Feel free to ping us on IRC if you need code review.

[1]

http://specs.openstack.org/openstack/oslo-specs/specs/policy/feature-freeze.html

-- Daniel Bengtsson Software Engineer

— Reply to this email directly, view it on GitHub https://github.com/SovereignCloudStack/issues/issues/489#issuecomment-1921592059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYAG3LQP63NXVEPL6E3XCK3YROYCZAVCNFSM6AAAAAA7VIY3HWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGU4TEMBVHE . You are receiving this because you were mentioned.Message ID: @.***>

[MatusJenca2]

O, I have written my concerns to the maintainers PR. After testing the changes I will let you know.

On Fri, Feb 2, 2024 at 12:09 PM Matus Jenca @.***> wrote:

I have troubles making kolla-ansible work with the second pull request, https://review.opendev.org/c/openstack/oslo.cache/+/907336 (from a core oslo maintainer), I'd perhaps consider merging mine. This still might be a problem on my end.

On Thu, Feb 1, 2024 at 4:28 PM Sven @.***> wrote:

I'll just quote my mail to SCS-Tech list here, for the sake of completeness:

Hi everyone,

seems we need to hurry if we want to get the needed patches into oslo.cache, as the feature freeze is nearing fast (see the attached mail).

Currently there are two different approaches to provide redis sentinel in oslo.cache:

https://review.opendev.org/c/openstack/oslo.cache/+/907211 (by Matus @dnation https://github.com/dnation) https://review.opendev.org/c/openstack/oslo.cache/+/907336 (from a core oslo maintainer)

if you can provide feedback on the patches, please do so asap.

Thanks

Sven

-------- Weitergeleitete Nachricht -------- Von: Daniel Bengtsson @.> An: @. Betreff: [oslo] Feature freeze. Datum: 01.02.2024 15:40:32

Hi there,

Just a friendly reminder that oslo's feature freeze will happen in 2 weeks (R-7 - Feb 12 - Feb 16). To know more about the freeze, we have a policy[1] that discusses it.

The main thing is that if you have features you want to get into Oslo libraries this cycle, please make sure they merge by Friday. After that we will need to go through the FFE process and there is no guarantee we can land them. Feel free to ping us on IRC if you need code review.

[1]

http://specs.openstack.org/openstack/oslo-specs/specs/policy/feature-freeze.html

-- Daniel Bengtsson Software Engineer

— Reply to this email directly, view it on GitHub https://github.com/SovereignCloudStack/issues/issues/489#issuecomment-1921592059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYAG3LQP63NXVEPL6E3XCK3YROYCZAVCNFSM6AAAAAA7VIY3HWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGU4TEMBVHE . You are receiving this because you were mentioned.Message ID: @.***>

[MatusJenca2]

In case we don't merge today: How long is the freeze?

On Fri, Feb 2, 2024 at 1:49 PM Matus Jenca @.***> wrote:

O, I have written my concerns to the maintainers PR. After testing the changes I will let you know.

On Fri, Feb 2, 2024 at 12:09 PM Matus Jenca @.***> wrote:

I have troubles making kolla-ansible work with the second pull request, https://review.opendev.org/c/openstack/oslo.cache/+/907336 (from a core oslo maintainer), I'd perhaps consider merging mine. This still might be a problem on my end.

On Thu, Feb 1, 2024 at 4:28 PM Sven @.***> wrote:

I'll just quote my mail to SCS-Tech list here, for the sake of completeness:

Hi everyone,

seems we need to hurry if we want to get the needed patches into oslo.cache, as the feature freeze is nearing fast (see the attached mail).

Currently there are two different approaches to provide redis sentinel in oslo.cache:

https://review.opendev.org/c/openstack/oslo.cache/+/907211 (by Matus @dnation https://github.com/dnation) https://review.opendev.org/c/openstack/oslo.cache/+/907336 (from a core oslo maintainer)

if you can provide feedback on the patches, please do so asap.

Thanks

Sven

-------- Weitergeleitete Nachricht -------- Von: Daniel Bengtsson @.> An: @. Betreff: [oslo] Feature freeze. Datum: 01.02.2024 15:40:32

Hi there,

Just a friendly reminder that oslo's feature freeze will happen in 2 weeks (R-7 - Feb 12 - Feb 16). To know more about the freeze, we have a policy[1] that discusses it.

The main thing is that if you have features you want to get into Oslo libraries this cycle, please make sure they merge by Friday. After that we will need to go through the FFE process and there is no guarantee we can land them. Feel free to ping us on IRC if you need code review.

[1]

http://specs.openstack.org/openstack/oslo-specs/specs/policy/feature-freeze.html

-- Daniel Bengtsson Software Engineer

— Reply to this email directly, view it on GitHub https://github.com/SovereignCloudStack/issues/issues/489#issuecomment-1921592059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYAG3LQP63NXVEPL6E3XCK3YROYCZAVCNFSM6AAAAAA7VIY3HWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGU4TEMBVHE . You are receiving this because you were mentioned.Message ID: @.***>

[MatusJenca2]

The core maintainer's pull request works for me, I gave it a +1. I don't know if I have permission to merge it. It should have a +2 as well. @artificial-intelligence can I merge it now?