search

SovereignCloudStack / opendesk-on-scs

Docs for openDesk on SCS
https://docs.scs.community/user-docs/application-examples/opendesk-on-scs/overview
Creative Commons Attribution Share Alike 4.0 International
1 stars 0 forks source link

Use to script on github to avoid it breaking on docs. #11

Closed garloff closed 1 month ago

garloff commented 1 month ago

Fixes issue #9 or so I hope at least.

garloff commented 1 month ago

So the commented out relative-link-path test in .markdownlint-cli2.jsonc did help to survive the markdownlint checks here, but these docs are pulled in from the docs page build and we still have the test there. As the helper script is not copied over in the docs page build (unless we specifically ask docusaurus to do so), the link would not work either. I assume it's best to link directly to github. Do this and switch own markdownlint test again. With this, I expect the docs page build to get green again.

garloff commented 1 month ago

Sidenote: I'm surprised this repo does not require an approving review for merging into main. Is this intentional?

tbreiden commented 1 month ago

@garloff Thanks for the hint.

fkr commented 1 month ago

Sidenote: I'm surprised this repo does not require an approving review for merging into main. Is this intentional?

that is because github-manager is not running properly and apparently this repo was also never really added to it properly. I'll look at that.

fkr commented 1 month ago

Sidenote: I'm surprised this repo does not require an approving review for merging into main. Is this intentional?

I've fixed github-manager yesterday and as such this repo should now be properly managed as well by github-manager.