search

SovereignCloudStack / opendesk-on-scs

Docs for openDesk on SCS
https://docs.scs.community/user-docs/application-examples/opendesk-on-scs/overview
Creative Commons Attribution Share Alike 4.0 International
1 stars 0 forks source link

helper/deploy-openDesk needs a review #13

Open scpcom opened 3 days ago

scpcom commented 3 days ago

Some lines are missing here: https://github.com/SovereignCloudStack/opendesk-on-scs/blob/main/helper/deploy-openDesk#L70

A fix may look like this:

diff --git a/helper/deploy-openDesk b/helper/deploy-openDesk
index 9a6c851..6e8ca60 100755
--- a/helper/deploy-openDesk
+++ b/helper/deploy-openDesk
@@ -67,7 +67,9 @@ spec:
       selector:
         dnsNames:
           - "*.${DOMAIN}"
-```
+EOF
+    kubectl apply -f cluster-issuer.yaml -n ${NAMESPACE}
+fi

 ###
 echo "Deploying openDesk on ${DOMAIN}" in namespace ${NAMESPACE}.

But the cluster-issuer.yaml seems to contain multiple configurations (my-dns-provider, letsencrypt-staging, letsencrypt-prod) which should be cleaned up or explained.

PS: The "example-env" described in quickstart is also not referenced in the script.