Feat/containerize application

SovereignCloudStack / rookify

Enable Ceph-Cluster migrations to Rook

https://scs.community/

Apache License 2.0

1 stars 0 forks source link

Feat/containerize application #24

Closed boekhorstb1 closed 2 weeks ago

boekhorstb1 commented 2 months ago

NOTE: this is currently dependent on https://github.com/SovereignCloudStack/rookify/pull/23

added Dockerfile for rookify: python3-rados is installed within the ceph container
added Makefile to build and run container of rookify
added Makefile command to setup venv locally

ISSUE:

ceph container works with python3.6, in centos I could not find python bindings for rados with 3.9

Closes: #2

boekhorstb1 commented 2 months ago

ok in the last commit I just added I changed some bigger things (please review):

using ceph container now (quincy v17.2.7), note: runs on python3.6 but has rados2.0.0
added some more information to pyproject.toml because build would not run otherwise
adapted Makefile a little (this MR will have most important changes)
remove rados from requirements.txt because the ceph container will contain it

@NotTheEvilOne @brueggemann

boekhorstb1 commented 2 months ago

ok so set the tag differently in the makefile as requested. Also set container to latest ceph image. Small annoyance (but I think nothing critical): python version in the container is still 3.6. But the build is works. After installing python 3.9 librados.so.2.0.0 is found anyhow.

boekhorstb1 commented 1 month ago

ok tested some more. Interestingly enough, the build works fine, but running rookify in the container does not work, because it cannot find rados for python 3.9. Problem is here: as far as I know, there are simply no ceph containers that use a higher python version than 3.6. Furthermore I could not find an rpm in the centos repos for python3-rados that offers interfaces for python 3.9 or higher.

b1-luettje commented 4 weeks ago

Since we're having a little bit of an chicken-egg-problem by either using the official ceph container image or the official python image we've decided to (try to) target ubuntu:24.04 (and its corresponding official packages) instead.

Pros:

Canonical "ensures" that import rados should always work after installing the official packages
24.04 is a LTS release

Cons:

No (more) explicit control over ceph and python versions but 3.12 is perfectly fine and librados2 seems very settled and therefore unlikely to change drastically in the next years. If necessary, we can always include upstream ceph repositories to upgrade ceph/librados2.

NotTheEvilOne commented 3 weeks ago

I've now updated Dockerfile to reflect the changes @b1-luettje described above and merged main to fix a TODO while working on it. It's ready to get merged in my eyes. Please have a look again @brueggemann and @yeoldegrove :)