SovereignCloudStack / rookify

Enable Ceph-Cluster migrations to Rook
https://scs.community/
Apache License 2.0
1 stars 0 forks source link

Add initial testing foundation #33

Closed NotTheEvilOne closed 2 weeks ago

NotTheEvilOne commented 2 months ago

This PR adds the initial testing foundation:

Closes #14

NotTheEvilOne commented 2 months ago

Additional note: I do not agree with all formatting rules applied. The still marked "formatting error" for the ternary operator does not make sense at all and mixes condition with return value for one but not both possibilities.

brueggemann commented 2 months ago

Additional note: I do not agree with all formatting rules applied. The still marked "formatting error" for the ternary operator does not make sense at all and mixes condition with return value for one but not both possibilities.

I don't really know, which rule was applied on that line, but I think, probably the line was to long with the else statement in the first line, so it did the line break before else?

In my opinion, the else in the second line is better to read, because now it is more visible, that the AUTH_FAILED is part of the ternary the line before

brueggemann commented 2 months ago

Please also use type hints for method arguments and return values