SovereignCloudStack / standards

SCS standards in a machine readable format
https://scs.community/
Creative Commons Attribution Share Alike 4.0 International
30 stars 21 forks source link

[BUG] Misleading error messages in standard flavors check #504

Closed Nils98Ar closed 3 months ago

Nils98Ar commented 3 months ago

./scs-compliance-check.py -V v4 ./scs-compatible-iaas.yaml --os-cloud=XYZ

Output:

[...]

DEBUG: Checking 28 flavor specs against 20 flavors
ERROR: Missing mandatory flavor 'SCS-1V-4'
ERROR: Missing mandatory flavor 'SCS-2V-8'
ERROR: Missing mandatory flavor 'SCS-4V-16'
ERROR: Missing mandatory flavor 'SCS-8V-32'
ERROR: Missing mandatory flavor 'SCS-1V-2'
ERROR: Missing mandatory flavor 'SCS-2V-4'
ERROR: Missing mandatory flavor 'SCS-4V-8'
ERROR: Missing mandatory flavor 'SCS-8V-16'
ERROR: Missing mandatory flavor 'SCS-16V-32'
ERROR: Missing mandatory flavor 'SCS-1V-8'
ERROR: Missing mandatory flavor 'SCS-2V-16'
ERROR: Missing mandatory flavor 'SCS-4V-32'
ERROR: Missing mandatory flavor 'SCS-1L-1'
ERROR: Missing mandatory flavor 'SCS-2V-4-20s'

[...]

But the flavors are there:

openstack flavor list -c Name

+----------------+
| Name           |
+----------------+
| SCS-2V-16      |
| SCS-1V-2       |
| SCS-2V-2       |
| SCS-16V-32     |
| SCS-2V-8       |
| SCS-4V-2       |
| SCS-1V-8       |
| SCS-1L-1       |
| SCS-8V-32      |
| SCS-4V-16      |
| SCS-4V-16-100s |
| SCS-4V-8       |
| SCS-8V-16      |
| SCS-1V-4       |
| SCS-8V-32-100s |
| SCS-4V-4       |
| SCS-2V-4       |
| SCS-2V-4-20s   |
| SCS-2V-1       |
| SCS-4V-32      |
+----------------+

And also the v3 test is passing with only INFOs and WARNINGs.

mbuechse commented 3 months ago

@Nils98Ar The extra_specs must be set in order for the flavors to be found. Without them, the test will fail either way, even if it found them.

mbuechse commented 3 months ago

So this is merely a matter of confusing output. We can rededicate this issue to improving the output.

Nils98Ar commented 3 months ago

Sounds good. I will try to re-create the flavors via openstack-flavor-manager while keeping the IDs.