SovereignCloudStack / standards

SCS standards in a machine readable format
https://scs.community/
Creative Commons Attribution Share Alike 4.0 International
34 stars 23 forks source link

[BUG] do not mark additional flavors as an error #574

Closed berendt closed 4 months ago

berendt commented 5 months ago

We have additional flavors which are not listed in the SCS standard and which contain all the necessary metadata. If these are present, they should not be marked as errors. The names of the flavors are valid according to the SCS standard.

ERROR: The following flavors are not standard, yet use a reserved property: SCS-2V-4-20: scs:name-v1, scs:name-v2, SCS-4V-8-50s: scs:name-v1, scs:name-v2, SCS-4V-8-50: scs:name-v1, scs:name-v2, SCS-8V-32-50: scs:name-v1, scs:name-v2, SCS-8V-64: scs:name-v1, scs:name-v2, SCS-1V-1-10: scs:name-v1, scs:name-v2
mbuechse commented 5 months ago

The test simply does what the standard says:

scs:name-vN=NAME (where N is 1 or 2, and NAME is some string) means that the flavor is one of the standard SCS flavors, and the requirements of Section "Standard SCS flavors" below apply.

berendt commented 5 months ago

But does that make sense? I would like to define flavors according to the SCS standard, but they are not specified as recommended or must in the standard. IMO, it makes sense to include all SCS meta information for these flavors as well.

berendt commented 5 months ago

@garloff Please have a look. We were supposed to discuss it today, but there wasn't time. Our v4 check is currently red as we are adding SCS metadata to flavors that are not listed as mandatory or recommended. I think that should be fine to provide additional flavors. At the moment, we're just not really sure how this is intended in the standard.

mbuechse commented 4 months ago

Kurt asked me via e-mail about the rationale, and I think it's not unappropriate to also reproduce my response here:

We would have to refer to some major version, or we would have to introduce some complicated mechanism by which it could be inferred from the context which one would apply. The context could be the certificate scope, but then these two realms would start bleeding into each other, which feels messy to me.

mbuechse commented 4 months ago

As discussed yesterday both in personal conversation and the SIG Std/Cert, it seems that this part of the standard (however many reasons it may have) doesn't work for the customers, so with the associated Pull Request we relax the test so as no longer to enforce said part.