search

SovereignCloudStack / standards

SCS standards in a machine readable format
https://scs.community/
Creative Commons Attribution Share Alike 4.0 International
34 stars 23 forks source link

Add ADR for Rook #737

Closed b1-lender closed 1 month ago

b1-lender commented 2 months ago

This PR adds an ADR regarding Rook. fixes: https://github.com/SovereignCloudStack/issues/issues/515

fkr commented 1 month ago

Thanks @b1-lender - this reads well. Since there are quite references to OSISM and its future direction (re. kubernetes), I think, it is important that @berendt comments. For the formal correctness, I think it makes sense that someone like @markus-hentsch or @mbuechse reviews it, they're good with that :)

mbuechse commented 1 month ago

ERROR: duplicates found: scs-0118-v1-rook-decision.md, scs-0118-v1-taxonomy-of-failsafe-levels.md

Why was this merged when the test failed so blatantly?

b1-lender commented 1 month ago

I didn't pay enough attention because merging was possible. What would be the preferred way to resolve this error, simply a new PR with the fix?

tonifinger commented 1 month ago

I didn't pay enough attention because merging was possible. What would be the preferred way to resolve this error, simply a new PR with the fix?

I already created a PR to fix this, because it is currently blocking a PR I'm working on: #767 Could i ask you to review it ?