search

Soviet5lo / SlashTHEM

Super Lotsa Added Stuff Hack - The Heavily Extended Mod: A variant of Slash'EM that adds a bunch of content.
30 stars 9 forks source link

Make blacksmith remember orders across saves #45

Closed gebulmer closed 3 years ago

gebulmer commented 3 years ago

This saves the time_remaining and weapon objects across saves, so the blacksmith doesn't scam you.

This loosely follows how objects are saved and loaded in {save,rest}objchn

Public servers should bump the EDITLEVEL as this breaks current saves

Relates to #44

k21971 commented 3 years ago

gebulmer - the variant author needs to adjust EDITLEVEL or whichever version number they want. Not the server op :)

Soviet5lo commented 3 years ago

I think EDITLEVEL is commented out as it's never been used, but I can re-enable it for this at least. Not particularly too sure that I'll make a specific tag/release for this however (plenty of savebreaking stuff coming soonish anyway).

Everything looks fine, I'll merge it in later this evening :+1:

k21971 commented 3 years ago

You don't need to re-enable EDITLEVEL if you don't want to. Out of all the variants I host, vanilla nethack (3.7.0 dev) is the only game that uses it. For a save-breaking change like this, bumping to 0.9.6 sounds appropriate. Plus as a server op, it keeps version organization nice and tidy on my end :)

Soviet5lo commented 3 years ago

I think that's fair. Smaller amount of commits but considering it contains mostly bug fixes (including one that's been around for years) I think it's fine.

I was going to wait on 0.9.6 until some racial changes were finished since they'll break saves as well, but I can save those for 0.9.7.